Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use common.mustNotCall in test-crypto-random #13183

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented May 24, 2017

Use common.mustNotCall() to confirm that noop callbacks are not run
when functions throw errors.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test crypto

test: use common.mustNotCall in test-crypto-random
Use `common.mustNotCall()` to confirm that noop callbacks are not run
when functions throw errors.

@Trott Trott added crypto test labels May 24, 2017

@lpinca
lpinca approved these changes May 24, 2017
@danbev
danbev approved these changes May 24, 2017
@Trott

This comment has been minimized.

Copy link
Member Author

commented May 24, 2017

Trott added a commit to Trott/io.js that referenced this pull request May 26, 2017
test: use common.mustNotCall in test-crypto-random
Use `common.mustNotCall()` to confirm that noop callbacks are not run
when functions throw errors.

PR-URL: nodejs#13183
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member Author

commented May 26, 2017

Landed in 112ef23

@Trott Trott closed this May 26, 2017

jasnell added a commit that referenced this pull request May 28, 2017
test: use common.mustNotCall in test-crypto-random
Use `common.mustNotCall()` to confirm that noop callbacks are not run
when functions throw errors.

PR-URL: #13183
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell jasnell referenced this pull request May 28, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.