Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip test-bindings if inspector is disabled #13186

Closed

Conversation

@danbev
Copy link
Member

commented May 24, 2017

If node is configured --without-inspector/--without-ssl this test will
fail with the following error:

Path: inspector/test-bindings
inspector.js:8
  throw new Error('Inspector is not available');
  ^

Error: Inspector is not available
    at inspector.js:8:9
    at NativeModule.compile (bootstrap_node.js:549:7)

This commit skips this test if the inspector is disabled.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

test: skip test-bindings if inspector is disabled
If node is configured --without-inspector/--without-ssl this test will
fail with the following error:
Path: inspector/test-bindings
inspector.js:8
  throw new Error('Inspector is not available');
  ^

Error: Inspector is not available
    at inspector.js:8:9
    at NativeModule.compile (bootstrap_node.js:549:7)

This commit skips this test if the inspector is disabled.
@danbev

This comment has been minimized.

Copy link
Member Author

commented May 24, 2017

@Trott
Trott approved these changes May 24, 2017
Copy link
Member

left a comment

LGTM if CI is green

@lpinca
lpinca approved these changes May 24, 2017
@lpinca

This comment has been minimized.

Copy link
Member

commented May 24, 2017

CI is not green :)

@danbev

This comment has been minimized.

Copy link
Member Author

commented May 24, 2017

@mhdawson
Copy link
Member

left a comment

LGTM

danbev added a commit to danbev/node that referenced this pull request May 26, 2017
test: skip test-bindings if inspector is disabled
If node is configured --without-inspector/--without-ssl this test will
fail with the following error:
Path: inspector/test-bindings
inspector.js:8
  throw new Error('Inspector is not available');
  ^

Error: Inspector is not available
    at inspector.js:8:9
    at NativeModule.compile (bootstrap_node.js:549:7)

This commit skips this test if the inspector is disabled.

PR-URL: nodejs#13186
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@danbev

This comment has been minimized.

Copy link
Member Author

commented May 26, 2017

Landed in ab28e0a

@danbev danbev closed this May 26, 2017

@danbev danbev deleted the danbev:skip-test-bindings-without-inspector branch May 26, 2017

jasnell added a commit that referenced this pull request May 28, 2017
test: skip test-bindings if inspector is disabled
If node is configured --without-inspector/--without-ssl this test will
fail with the following error:
Path: inspector/test-bindings
inspector.js:8
  throw new Error('Inspector is not available');
  ^

Error: Inspector is not available
    at inspector.js:8:9
    at NativeModule.compile (bootstrap_node.js:549:7)

This commit skips this test if the inspector is disabled.

PR-URL: #13186
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@jasnell jasnell referenced this pull request May 28, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants
You can’t perform that action at this time.