New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async_hooks: rename AsyncEvent to AsyncResource #13192

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@addaleax
Member

addaleax commented May 24, 2017

AsyncEvent is not a good name given its semantics.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

async_hooks

async_hooks: rename AsyncEvent to AsyncResource
`AsyncEvent` is not a good name given its semantics.

@addaleax addaleax added this to the 8.0.0 milestone May 24, 2017

@addaleax addaleax referenced this pull request May 24, 2017

Closed

async_hooks: implement C++ embedder API #13142

4 of 4 tasks complete
@Fishrock123

Agreed.

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax May 26, 2017

Member

Landed in 90dee89

Member

addaleax commented May 26, 2017

Landed in 90dee89

@addaleax addaleax closed this May 26, 2017

@addaleax addaleax deleted the addaleax:asyncevent-to-asyncresource branch May 26, 2017

addaleax added a commit that referenced this pull request May 26, 2017

async_hooks: rename AsyncEvent to AsyncResource
`AsyncEvent` is not a good name given its semantics.

PR-URL: #13192
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

jasnell added a commit that referenced this pull request May 28, 2017

async_hooks: rename AsyncEvent to AsyncResource
`AsyncEvent` is not a good name given its semantics.

PR-URL: #13192
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@jasnell jasnell referenced this pull request May 28, 2017

Closed

8.0.0 Release Proposal #12220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment