Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: add comment for TicketKeyCallback #13193

Closed
wants to merge 1 commit into from

Conversation

@addaleax
Copy link
Member

commented May 24, 2017

Fixes: #13176

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src/crypto

@lpinca
lpinca approved these changes May 24, 2017
@@ -1202,6 +1202,8 @@ void SecureContext::SetFreeListLength(const FunctionCallbackInfo<Value>& args) {
}


// Currently, EnableTicketKeyCallback and TicketKeyCallback are only present for
// the regression test in test/parallel/test-https-resume-after-renew.js.

This comment has been minimized.

Copy link
@refack

refack May 24, 2017

Member

[suggestion] If i understand this case correctly add , they are considered private until decided otherwise.
Also maybe add _ to the JS binding.

This comment has been minimized.

Copy link
@addaleax

addaleax May 24, 2017

Author Member

I think it’s implied that they are private when they are only there for tests. Also, this is only on the _handle property, so I think we’re good.

This comment has been minimized.

Copy link
@refack
@refack
refack approved these changes May 24, 2017
@addaleax

This comment has been minimized.

Copy link
Member Author

commented May 26, 2017

Landed in e2f2d18

@addaleax addaleax closed this May 26, 2017

@addaleax addaleax deleted the addaleax:ticketkeycallback-comment branch May 26, 2017

addaleax added a commit that referenced this pull request May 26, 2017
src: add comment for TicketKeyCallback
Fixes: #13176
PR-URL: #13193
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
jasnell added a commit that referenced this pull request May 28, 2017
src: add comment for TicketKeyCallback
Fixes: #13176
PR-URL: #13193
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@jasnell jasnell referenced this pull request May 28, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
MylesBorins added a commit that referenced this pull request Jul 17, 2017
src: add comment for TicketKeyCallback
Fixes: #13176
PR-URL: #13193
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.