Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: check noop invocation with mustNotCall() #13205

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented May 24, 2017

In test-child-process-spawnsync-validation-errors, check that functions
used inappropriately as options are not invoked.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test child_process

test: check noop invocation with mustNotCall()
In test-child-process-spawnsync-validation-errors, check that functions
used inappropriately as options are not invoked.
@Trott

This comment has been minimized.

Copy link
Member Author

commented May 24, 2017

@refack
refack approved these changes May 24, 2017
@lpinca
lpinca approved these changes May 25, 2017
@Trott

This comment has been minimized.

Copy link
Member Author

commented May 26, 2017

Landed in d64d361

@Trott Trott closed this May 26, 2017

Trott added a commit to Trott/io.js that referenced this pull request May 26, 2017
test: check noop invocation with mustNotCall()
In test-child-process-spawnsync-validation-errors, check that functions
used inappropriately as options are not invoked.

PR-URL: nodejs#13205
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell added a commit that referenced this pull request May 28, 2017
test: check noop invocation with mustNotCall()
In test-child-process-spawnsync-validation-errors, check that functions
used inappropriately as options are not invoked.

PR-URL: #13205
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell jasnell referenced this pull request May 28, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.