New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: ignore more VC++ artifacts #13208

Merged
merged 0 commits into from May 27, 2017

Conversation

Projects
None yet
7 participants
@refack
Member

refack commented May 24, 2017

Checklist
Affected core subsystem(s)

build,tools

@refack

This comment has been minimized.

Show comment
Hide comment
@refack
Member

refack commented May 24, 2017

@refack refack requested a review from joshgav May 24, 2017

@refack refack self-assigned this May 24, 2017

@gibfahn

This comment has been minimized.

Show comment
Hide comment
@gibfahn

gibfahn May 24, 2017

Member

What does *.exe match in the top level?

Member

gibfahn commented May 24, 2017

What does *.exe match in the top level?

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack May 24, 2017

Member

for all sort of scripts we need ./node to be resolvable

Member

refack commented May 24, 2017

for all sort of scripts we need ./node to be resolvable

@gibfahn

This comment has been minimized.

Show comment
Hide comment
@gibfahn

gibfahn May 25, 2017

Member

for all sort of scripts we need ./node to be resolvable

I thought all the scripts used Release\node.exe for windows

Member

gibfahn commented May 25, 2017

for all sort of scripts we need ./node to be resolvable

I thought all the scripts used Release\node.exe for windows

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack May 25, 2017

Member

I started using make lint

Member

refack commented May 25, 2017

I started using make lint

@Fishrock123

This comment has been minimized.

Show comment
Hide comment
@Fishrock123

Fishrock123 May 25, 2017

Member

I started using make lint

Sorry, what does that have to do with the above comment?

I thought all the scripts used Release\node.exe for windows

Member

Fishrock123 commented May 25, 2017

I started using make lint

Sorry, what does that have to do with the above comment?

I thought all the scripts used Release\node.exe for windows

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack May 25, 2017

Member

I started using make lint
Sorry, what does that have to do with the above comment?

I thought all the scripts used Release\node.exe for windows

The commands in Makefile assume NODE ?= ./$(NODE_EXE), so if I want to enjoy them I need to either symlink the exe, or keep specifying NODE=...
P.S. I'm using MSYS make in a regular (non WSL) environment.

Member

refack commented May 25, 2017

I started using make lint
Sorry, what does that have to do with the above comment?

I thought all the scripts used Release\node.exe for windows

The commands in Makefile assume NODE ?= ./$(NODE_EXE), so if I want to enjoy them I need to either symlink the exe, or keep specifying NODE=...
P.S. I'm using MSYS make in a regular (non WSL) environment.

@refack refack closed this May 27, 2017

@refack refack merged commit c1a4b53 into nodejs:master May 27, 2017

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack May 27, 2017

Member

Landed c1a4b53

Member

refack commented May 27, 2017

Landed c1a4b53

@refack refack deleted the refack:ignore-vs-artifacts branch May 27, 2017

jasnell added a commit that referenced this pull request May 28, 2017

build: ignore more VC++ artifacts
PR-URL: #13208
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@jasnell jasnell referenced this pull request May 28, 2017

Closed

8.0.0 Release Proposal #12220

@refack refack removed their assignment Jun 12, 2017

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete

MylesBorins added a commit that referenced this pull request Jul 17, 2017

build: ignore more VC++ artifacts
PR-URL: #13208
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Jul 18, 2017

Merged

v6.11.2 proposal #14356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment