Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
test: replace `indexOf` with `includes` #13215
I have mixed feelings in backporting this to v6.x. @nodejs/v8 is this something we need to be concerned about from a performance standpoint?
If the change is fairly moot in 8.x, but causes problems on 6.x, I'm not convinced the churn is worth it (as it will make backporting harder). I would appreciate if this type of research could be done before landing these changes wholesale.
If this has already been researched and it is a non issue please accept my humble apologies for crankiness in the above paragraph
This was discussed re backporting in #12586 (comment) and was "empirically" tested for compatibility.
Hope this info helps.
As @refack says, only
I assume we'd plan to wait till v6.x goes into maintenance before considering changes to
We did discuss this in an LTS meeting: #12586 (comment) and https://github.com/nodejs/LTS/blob/master/doc/meetings/2017-04-24.md#backporting-test-fixes-to-maintenance-branches-205
Sounds like backporting induced PTSD to me