Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: remove dup property #13216

Merged
merged 1 commit into from May 25, 2017

Conversation

@calvinmetcalf
Copy link
Member

commented May 25, 2017

looks like #12828 accidentally got a double property definition, as mentioned here, this removes that

@lpinca
lpinca approved these changes May 25, 2017
@calvinmetcalf

This comment has been minimized.

Copy link
Member Author

commented May 25, 2017

considering how trivial this is I'll plan on landing this in the next hour or 2 unless anyone objects

@addaleax
Copy link
Member

left a comment

Agreed, I’m good with landing this now

@calvinmetcalf

This comment has been minimized.

Copy link
Member Author

commented May 25, 2017

@addaleax whats your email so I can include you in the reviewed lines ?

@addaleax

This comment has been minimized.

Copy link
Member

commented May 25, 2017

@calvinmetcalf anna@addaleax.net … if you’re unsure about those, you can always just copy the lines from our README :)

@lpinca

This comment has been minimized.

Copy link
Member

commented May 25, 2017

@calvinmetcalf I usually copy/paste the latest available in git log after searching reviewer by name.

stream: remove dup property
PR-URL: #13216
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@calvinmetcalf calvinmetcalf force-pushed the calvinmetcalf:stream-final-dup-prop branch to 155687c May 25, 2017

@calvinmetcalf

This comment has been minimized.

Copy link
Member Author

commented May 25, 2017

@lpinca I had been doing that but couldn't find it in any recent ones and totally forgot about her email in the readme

@calvinmetcalf

This comment has been minimized.

Copy link
Member Author

commented May 25, 2017

@calvinmetcalf calvinmetcalf merged commit 155687c into nodejs:master May 25, 2017

jasnell added a commit that referenced this pull request May 25, 2017
stream: remove dup property
PR-URL: #13216
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell added a commit that referenced this pull request May 28, 2017
stream: remove dup property
PR-URL: #13216
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@jasnell jasnell referenced this pull request May 28, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
@MylesBorins

This comment has been minimized.

Copy link
Member

commented Jul 17, 2017

This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.