Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor test-fs-assert-encoding-error #13226

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented May 25, 2017

Check that callbacks are not executed when errors are expected to be
thrown.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test fs

test: refactor test-fs-assert-encoding-error
Check that callbacks are not executed when errors are expected to be
thrown.

@Trott Trott added fs test labels May 25, 2017

@Trott

This comment has been minimized.

Copy link
Member Author

commented May 25, 2017

@refack
refack approved these changes May 25, 2017
@lpinca
lpinca approved these changes May 26, 2017
Trott added a commit to Trott/io.js that referenced this pull request May 29, 2017
test: refactor test-fs-assert-encoding-error
Check that callbacks are not executed when errors are expected to be
thrown.

PR-URL: nodejs#13226
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member Author

commented May 29, 2017

Landed in f00475d

@Trott Trott closed this May 29, 2017

jasnell added a commit that referenced this pull request May 29, 2017
test: refactor test-fs-assert-encoding-error
Check that callbacks are not executed when errors are expected to be
thrown.

PR-URL: #13226
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.