New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove Gitter badge from README #13231

Closed
wants to merge 1 commit into
base: master
from

Conversation

@Trott
Member

Trott commented May 26, 2017

Remove the Gitter badge. Gitter is not supported by us. We use IRC channels on Freenode. Having the Gitter badge is confusing because we list different resources later in the doc and never mention Gitter.

Checklist
Affected core subsystem(s)

doc

@Trott Trott added the doc label May 26, 2017

@Trott Trott changed the title from doc: remove low-value badges from README to doc: remove badges from README May 26, 2017

@refack

refack approved these changes May 26, 2017

@evanlucas

This comment has been minimized.

Show comment
Hide comment
@evanlucas

evanlucas May 26, 2017

Member

/cc @rvagg since you helped get the CII badge added in #6819

Member

evanlucas commented May 26, 2017

/cc @rvagg since you helped get the CII badge added in #6819

@cjihrig

LGTM and 👍 to the branch name

@silverwind

LGTM, they are pretty much noise.

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell May 28, 2017

Member

I'm +1 on removing the gitter badge. My preference on the CII badge would be to simply move it further down the page... perhaps at the bottom just as additional information.

Member

jasnell commented May 28, 2017

I'm +1 on removing the gitter badge. My preference on the CII badge would be to simply move it further down the page... perhaps at the bottom just as additional information.

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott May 29, 2017

Member

Since there is some hesitation at removing the Core Infrastructure Initiative badge, I've dialed this back to just removing the Gitter badge, for which there is consensus. (If anyone wants to either relocate or remove the CII badge too, please open another PR!)

Member

Trott commented May 29, 2017

Since there is some hesitation at removing the Core Infrastructure Initiative badge, I've dialed this back to just removing the Gitter badge, for which there is consensus. (If anyone wants to either relocate or remove the CII badge too, please open another PR!)

@Trott Trott changed the title from doc: remove badges from README to doc: remove gitter badge from README May 29, 2017

@Trott Trott changed the title from doc: remove gitter badge from README to doc: remove Gitter badge from README May 29, 2017

doc: remove Gitter badge from README
Remove the Gitter badge.

Gitter is not supported by us. We use IRC channels on Freenode. Having
the Gitter badge is confusing because we list different resources
later in the doc and never mention Gitter.

Trott added a commit to Trott/io.js that referenced this pull request May 29, 2017

doc: remove Gitter badge from README
Remove the Gitter badge.

Gitter is not supported by us. We use IRC channels on Freenode. Having
the Gitter badge is confusing because we list different resources
later in the doc and never mention Gitter.

PR-URL: nodejs#13231
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott May 29, 2017

Member

Landed in 19fdb54

Member

Trott commented May 29, 2017

Landed in 19fdb54

@Trott Trott closed this May 29, 2017

@refack refack referenced this pull request May 29, 2017

Closed

doc: relocate CII badge #13283

3 of 3 tasks complete
@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack May 29, 2017

Member

(If anyone wants to either relocate or remove the CII badge too, please open another PR!)

#13283

Member

refack commented May 29, 2017

(If anyone wants to either relocate or remove the CII badge too, please open another PR!)

#13283

jasnell added a commit that referenced this pull request May 29, 2017

doc: remove Gitter badge from README
Remove the Gitter badge.

Gitter is not supported by us. We use IRC channels on Freenode. Having
the Gitter badge is confusing because we list different resources
later in the doc and never mention Gitter.

PR-URL: #13231
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

@cjihrig cjihrig referenced this pull request Jun 6, 2017

Closed

Update README.md #13502

0 of 4 tasks complete

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete

MylesBorins added a commit that referenced this pull request Jul 17, 2017

doc: remove Gitter badge from README
Remove the Gitter badge.

Gitter is not supported by us. We use IRC channels on Freenode. Having
the Gitter badge is confusing because we list different resources
later in the doc and never mention Gitter.

PR-URL: #13231
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

@MylesBorins MylesBorins referenced this pull request Jul 18, 2017

Merged

v6.11.2 proposal #14356

@gibfahn gibfahn referenced this pull request Feb 21, 2018

Closed

doc: remove CII badge in README #18908

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment