New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: make spelling of behavior consistent #13245

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
9 participants
@mhdawson
Member

mhdawson commented May 26, 2017

In the api docs there were some instances of behaviour
and many more with behavior. I was asked as part of a review
on a different PR which one to use and went with behavior
to be consistent with the majority.

Not sure if we should mandate the US or english spelling but
this makes the api docs consistent.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows [commit guidelines]
Affected core subsystem(s)

doc

doc: make spelling of behavior consistent
In the api docs there were some instances of behaviour
and many more with behavior.  I was asked as part of a review
on a different PR which one to use and went with behavior
to be consistent with the majority.

Not sure if we should mandate the US or english spelling but
this makes the api docs consistent.
@aqrln

aqrln approved these changes May 26, 2017

LGTM. STYLE_GUIDE.md explicitly states that we use American English spelling.

@kunalspathak

This comment has been minimized.

Show comment
Hide comment
@kunalspathak

kunalspathak May 26, 2017

Contributor

There is one in https://github.com/nodejs/node/blob/master/doc/api/crypto.md that you might want to change. LGTM otherwise.

Contributor

kunalspathak commented May 26, 2017

There is one in https://github.com/nodejs/node/blob/master/doc/api/crypto.md that you might want to change. LGTM otherwise.

@mhdawson

This comment has been minimized.

Show comment
Hide comment
@mhdawson

mhdawson May 26, 2017

Member

@aqrln thanks, good to@ know that.

@kunalspathak thanks. I'd used a grep but only with lower case, will add that one.

Member

mhdawson commented May 26, 2017

@aqrln thanks, good to@ know that.

@kunalspathak thanks. I'd used a grep but only with lower case, will add that one.

@mhdawson

This comment has been minimized.

Show comment
Hide comment
@mhdawson

mhdawson May 26, 2017

Member

Pushed commit to address comments so far.

Member

mhdawson commented May 26, 2017

Pushed commit to address comments so far.

@Trott

Trott approved these changes May 26, 2017

LGTM

@lpinca

lpinca approved these changes May 27, 2017

@targos

targos approved these changes May 28, 2017

@targos

This comment has been minimized.

Show comment
Hide comment
@targos

targos May 28, 2017

Member

Landed in 5b50501

Member

targos commented May 28, 2017

Landed in 5b50501

@targos targos closed this May 28, 2017

targos added a commit that referenced this pull request May 28, 2017

doc: make spelling of behavior consistent
In the api docs there were some instances of behaviour
and many more with behavior.  I was asked as part of a review
on a different PR which one to use and went with behavior
to be consistent with the majority.

Our style guide states that American English spelling is preferred.

PR-URL: #13245
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com>

jasnell added a commit that referenced this pull request May 28, 2017

doc: make spelling of behavior consistent
In the api docs there were some instances of behaviour
and many more with behavior.  I was asked as part of a review
on a different PR which one to use and went with behavior
to be consistent with the majority.

Our style guide states that American English spelling is preferred.

PR-URL: #13245
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com>

@jasnell jasnell referenced this pull request May 28, 2017

Closed

8.0.0 Release Proposal #12220

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete

@mhdawson mhdawson deleted the mhdawson:behaviour branch Jun 28, 2017

MylesBorins added a commit that referenced this pull request Jul 17, 2017

doc: make spelling of behavior consistent
In the api docs there were some instances of behaviour
and many more with behavior.  I was asked as part of a review
on a different PR which one to use and went with behavior
to be consistent with the majority.

Our style guide states that American English spelling is preferred.

PR-URL: #13245
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com>

@MylesBorins MylesBorins referenced this pull request Jul 18, 2017

Merged

v6.11.2 proposal #14356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment