New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade npm to 5.0.0 #13276

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@zkat
Contributor

zkat commented May 29, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
  • deps
Description of Changes

This is the final version of npm@5.0.0! It's pretty much the same as the beta.56 release that was submitted before, but has some bugfixes from the rest of the beta. We went kinda fast so I don't have a concrete list of changes since then, but you can check the new changelog for overall details.

Please note that npm5 is a major update to npm, and is still fairly young. I fully expect users to find all sorts of doozies, even after a month of beta, and even longer of internal testing. We'll be doing tighter release cycles while npm5 stabilizes, though, and update-notifier should help users keep up to date even if new versions take a few more days to land in node@8. This is mostly a general comment about Super Fresh™ software.

I want to thank y'all on the node team for keeping this window open and being communicative with the npm team about your needs/expectations. I feel pretty good about this release even with the deadline having been so tight. 🎉

Note: tomorrow is a company holiday, but I've shifted my day off to Friday so I can be available to help get this release out the door. Please do let me know if you ned anything.

Changelog

@bricss bricss referenced this pull request May 29, 2017

Closed

8.0.0 Release Proposal #12220

@jasnell jasnell added this to the 8.0.0 milestone May 29, 2017

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell May 29, 2017

Member

@nodejs/ctc @nodejs/collaborators @nodejs/npm ... we'll need to fast track this to land today in order to make it in to the 8.0.0 release.

Member

jasnell commented May 29, 2017

@nodejs/ctc @nodejs/collaborators @nodejs/npm ... we'll need to fast track this to land today in order to make it in to the 8.0.0 release.

@jasnell

Rubber stamp LGTM

@cjihrig

Also rubber stamp LGTM

@Fishrock123

This comment has been minimized.

Show comment
Hide comment
@Fishrock123

Fishrock123 May 29, 2017

Member

Taking a look now.

Member

Fishrock123 commented May 29, 2017

Taking a look now.

@Fishrock123

This comment has been minimized.

Show comment
Hide comment
@Fishrock123

Fishrock123 May 29, 2017

Member

Seems good. As a note, more tests are now skipped on my machine:

total ........................................... 4417/4428

  4417 passing (9m)
  11 pending

Previously, only one was. (The couchdb one(s) I think.)

Member

Fishrock123 commented May 29, 2017

Seems good. As a note, more tests are now skipped on my machine:

total ........................................... 4417/4428

  4417 passing (9m)
  11 pending

Previously, only one was. (The couchdb one(s) I think.)

@Fishrock123 Fishrock123 reopened this May 29, 2017

@Fishrock123

(That was not the button I was looking for.)

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax May 29, 2017

Member

Landed in c58cea5

Member

addaleax commented May 29, 2017

Landed in c58cea5

@addaleax addaleax closed this May 29, 2017

vsemozhetbyt pushed a commit to vsemozhetbyt/node that referenced this pull request May 29, 2017

deps: upgrade npm to 5.0.0
PR-URL: nodejs#13276
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

jasnell added a commit that referenced this pull request May 29, 2017

deps: upgrade npm to 5.0.0
PR-URL: #13276
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@zkat

This comment has been minimized.

Show comment
Hide comment
@zkat

zkat May 29, 2017

Contributor

The skipped tests are pretty safe. They're just placeholders in @iarna's file specifier tests that haven't been filled in yet.

Contributor

zkat commented May 29, 2017

The skipped tests are pretty safe. They're just placeholders in @iarna's file specifier tests that haven't been filled in yet.

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment