Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors,process: migrate to use internal/errors.js #13285

Closed
wants to merge 1 commit into from

Conversation

@sreepurnajasti
Copy link
Contributor

@sreepurnajasti sreepurnajasti commented May 29, 2017

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

lib/internal/process.js
lib/internal/errors.js

ref: #11273

lib/internal/errors.js Outdated
@@ -151,6 +152,7 @@ E('ERR_SOCKET_BAD_TYPE',
E('ERR_SOCKET_CANNOT_SEND', 'Unable to send data');
E('ERR_SOCKET_BAD_PORT', 'Port should be > 0 and < 65536');
E('ERR_SOCKET_DGRAM_NOT_RUNNING', 'Not running');
E('ERR_V8BREAKITERATOR', 'full ICU data not installed. See https://github.com/nodejs/node/wiki/Intl');

This comment has been minimized.

@jasnell

jasnell May 30, 2017
Member

long line here. please line wrap at <= 80 chars.
Running make lint should catch these :-)

This comment has been minimized.

@sreepurnajasti

sreepurnajasti May 30, 2017
Author Contributor

@jasnell Unfortunately, on jslint test, this error is not showed up. Now, this is done. Thank you.

Copy link
Member

@jasnell jasnell left a comment

LGTM with a nit.

@sreepurnajasti sreepurnajasti force-pushed the sreepurnajasti:my-branch branch May 30, 2017
Copy link
Member

@mhdawson mhdawson left a comment

LGTM

@mhdawson
Copy link
Member

@mhdawson mhdawson commented May 31, 2017

CI run good, will land tomorrow once 48 hours has passed.

@mhdawson
Copy link
Member

@mhdawson mhdawson commented May 31, 2017

Actually 48 hours is already up landing.

@mhdawson
Copy link
Member

@mhdawson mhdawson commented May 31, 2017

Actually looking again as part of landing I think its better to avoid adding:

// Flags: --expose-internals

and just use TypeError instead of errors.TypeError etc when possible. @sreepurnajasti can you make that change?

@jasnell
Copy link
Member

@jasnell jasnell commented Jun 2, 2017

This needs a rebase before it can land. Thank you!

@mhdawson
Copy link
Member

@mhdawson mhdawson commented Jun 2, 2017

@sreepurnajasti can you can rebase and remove the use of --expose-internals.

@sreepurnajasti sreepurnajasti force-pushed the sreepurnajasti:my-branch branch to 8d8db6e Jun 2, 2017
@sreepurnajasti
Copy link
Contributor Author

@sreepurnajasti sreepurnajasti commented Jun 2, 2017

@jasnell @mhdawson I rebased. Also removed --expose-internals. Thank you

@jasnell
Copy link
Member

@jasnell jasnell commented Jun 2, 2017

@@ -160,6 +161,8 @@ E('ERR_SOCKET_BAD_TYPE',
E('ERR_SOCKET_CANNOT_SEND', 'Unable to send data');
E('ERR_SOCKET_BAD_PORT', 'Port should be > 0 and < 65536');
E('ERR_SOCKET_DGRAM_NOT_RUNNING', 'Not running');
E('ERR_V8BREAKITERATOR', 'full ICU data not installed.' +
'See https://github.com/nodejs/node/wiki/Intl');

This comment has been minimized.

@addaleax

addaleax Jun 2, 2017
Member

There should be a space after installed., right?

This comment has been minimized.

@jasnell

jasnell Jun 2, 2017
Member

good catch

@mhdawson
Copy link
Member

@mhdawson mhdawson commented Jun 5, 2017

CI run good, landing. Will add space.

@mhdawson
Copy link
Member

@mhdawson mhdawson commented Jun 5, 2017

Landed as 062071a

@mhdawson mhdawson closed this Jun 5, 2017
mhdawson added a commit that referenced this pull request Jun 5, 2017
PR-URL: #13285
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@jasnell jasnell added the semver-major label Jun 5, 2017
@refack refack added this to Done in Error Codes Aug 20, 2017
@sreepurnajasti sreepurnajasti deleted the sreepurnajasti:my-branch branch Dec 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Error Codes
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.