GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@jasnell, pinging you for mentoring as this is my first PR to this project, thank you!
make -j4 test
Unfortunately this needs a rebase.
Done the rebase and resolved the conflicts. Please review it. Thanks
errors,_stream_wrap: change _stream_wrap.js to use internal/errors.js
CI run: https://ci.nodejs.org/job/node-test-pull-request/8690/
errors,stream_wrap: use internal/errors.js
Reviewed-By: James M Snell <email@example.com>
Reviewed-By: Tobias Nießen <firstname.lastname@example.org>
Reviewed-By: Michael Dawson <email@example.com>
Landed in d291338, thank you for your contribution! 🎉
Labelled this semver-major as I think it should have been (not that there’s anything wrong with the patch), if I’m wrong feel free to remove the label.
@addaleax The error message did not change, why would this be semver-major?
@tniessen The error message changed from Error: Stream has StringDecoder to Error [ERR_STREAM_HAS_STRINGDECODER]: Stream has StringDecoder
Error: Stream has StringDecoder
Error [ERR_STREAM_HAS_STRINGDECODER]: Stream has StringDecoder
@addaleax Right, my bad.