New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors,_stream_wrap: change _stream_wrap.js to use internal/errors.js #13291

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@LakshmiSwethaG
Contributor

LakshmiSwethaG commented May 30, 2017

Refs: #11273

@jasnell, pinging you for mentoring as this is my first PR to this project, thank you!

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows [commit guidelines]
Affected core subsystem(s)

_stream_wrap.js

Show outdated Hide outdated lib/_stream_wrap.js Outdated
Show outdated Hide outdated lib/_stream_wrap.js Outdated
@mhdawson

This comment has been minimized.

Show comment
Hide comment
@mhdawson

mhdawson Jun 6, 2017

Member

Unfortunately this needs a rebase.

Member

mhdawson commented Jun 6, 2017

Unfortunately this needs a rebase.

@LakshmiSwethaG

This comment has been minimized.

Show comment
Hide comment
@LakshmiSwethaG

LakshmiSwethaG Jun 7, 2017

Contributor

Done the rebase and resolved the conflicts. Please review it. Thanks

Contributor

LakshmiSwethaG commented Jun 7, 2017

Done the rebase and resolved the conflicts. Please review it. Thanks

@jasnell

jasnell approved these changes Jun 9, 2017

@mhdawson

This comment has been minimized.

Show comment
Hide comment
Member

mhdawson commented Jun 16, 2017

@tniessen tniessen self-assigned this Jun 17, 2017

@tniessen tniessen added the errors label Jun 17, 2017

tniessen added a commit that referenced this pull request Jun 20, 2017

errors,stream_wrap: use internal/errors.js
PR-URL: #13291
Refs: #11273
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@tniessen

This comment has been minimized.

Show comment
Hide comment
@tniessen

tniessen Jun 20, 2017

Member

Landed in d291338, thank you for your contribution! 🎉

Member

tniessen commented Jun 20, 2017

Landed in d291338, thank you for your contribution! 🎉

@tniessen tniessen closed this Jun 20, 2017

@jasnell jasnell referenced this pull request Jun 20, 2017

Closed

Tracking Issue: Migrate errors to internal/errors.js #11273

78 of 80 tasks complete
@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Jun 20, 2017

Member

Labelled this semver-major as I think it should have been (not that there’s anything wrong with the patch), if I’m wrong feel free to remove the label.

Member

addaleax commented Jun 20, 2017

Labelled this semver-major as I think it should have been (not that there’s anything wrong with the patch), if I’m wrong feel free to remove the label.

@tniessen

This comment has been minimized.

Show comment
Hide comment
@tniessen

tniessen Jun 20, 2017

Member

@addaleax The error message did not change, why would this be semver-major?

Member

tniessen commented Jun 20, 2017

@addaleax The error message did not change, why would this be semver-major?

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Jun 20, 2017

Member

@tniessen The error message changed from Error: Stream has StringDecoder to Error [ERR_STREAM_HAS_STRINGDECODER]: Stream has StringDecoder

Member

addaleax commented Jun 20, 2017

@tniessen The error message changed from Error: Stream has StringDecoder to Error [ERR_STREAM_HAS_STRINGDECODER]: Stream has StringDecoder

@tniessen

This comment has been minimized.

Show comment
Hide comment
@tniessen

tniessen Jun 20, 2017

Member

@addaleax Right, my bad.

Member

tniessen commented Jun 20, 2017

@addaleax Right, my bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment