GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make -j4 test
This is my first contribution in node. I read and understood the contribution guidelines, please review and suggest.
@mhdawson @fhinkel ... could I ask one of you to please give this a review :-) thank you!
LGTM once --expose-internals is removed.
errors,util: migrate to use internal/errors.js
Done as per suggestion. Thanks! @mhdawson
@bidipyne thanks :)
CI run: https://ci.nodejs.org/job/node-test-pull-request/8439/
Reviewed-By: James M Snell <email@example.com>
Reviewed-By: Michael Dawson <firstname.lastname@example.org>
Landed in 1609899