New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors,util: migrate to use internal/errors.js #13293

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
6 participants
@bidipyne
Contributor

bidipyne commented May 30, 2017

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

util.js

ref: #11273

This is my first contribution in node. I read and understood the contribution guidelines, please review and suggest.
@jasnell
Thanks.

@jasnell

jasnell approved these changes Jun 1, 2017

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Jun 2, 2017

Member

@mhdawson @fhinkel ... could I ask one of you to please give this a review :-) thank you!

Member

jasnell commented Jun 2, 2017

@mhdawson @fhinkel ... could I ask one of you to please give this a review :-) thank you!

@mhdawson

LGTM once --expose-internals is removed.

Show outdated Hide outdated test/parallel/test-util-inspect.js Outdated
@bidipyne

This comment has been minimized.

Show comment
Hide comment
@bidipyne

bidipyne Jun 2, 2017

Contributor

Done as per suggestion. Thanks! @mhdawson

Contributor

bidipyne commented Jun 2, 2017

Done as per suggestion. Thanks! @mhdawson

@mhdawson

This comment has been minimized.

Show comment
Hide comment
Member

mhdawson commented Jun 2, 2017

jasnell added a commit that referenced this pull request Jun 2, 2017

errors,util: migrate to use internal/errors.js
PR-URL: #13293
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Jun 2, 2017

Member

Landed in 1609899

Member

jasnell commented Jun 2, 2017

Landed in 1609899

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment