Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors,util: migrate to use internal/errors.js #13293

Closed
wants to merge 1 commit into from

Conversation

@bidipyne
Copy link
Contributor

@bidipyne bidipyne commented May 30, 2017

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

util.js

ref: #11273

This is my first contribution in node. I read and understood the contribution guidelines, please review and suggest.
@jasnell
Thanks.

@jasnell
jasnell approved these changes Jun 1, 2017
@jasnell
Copy link
Member

@jasnell jasnell commented Jun 2, 2017

@mhdawson @fhinkel ... could I ask one of you to please give this a review :-) thank you!

Copy link
Member

@mhdawson mhdawson left a comment

LGTM once --expose-internals is removed.

test/parallel/test-util-inspect.js Outdated
@@ -19,6 +19,7 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.

// Flag: --expose-internals

This comment has been minimized.

@mhdawson

mhdawson Jun 2, 2017
Member

I don' think we need --expose-internals

@bidipyne
Copy link
Contributor Author

@bidipyne bidipyne commented Jun 2, 2017

Done as per suggestion. Thanks! @mhdawson

jasnell added a commit that referenced this pull request Jun 2, 2017
PR-URL: #13293
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@jasnell
Copy link
Member

@jasnell jasnell commented Jun 2, 2017

Landed in 1609899

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Error Codes
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.