New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors,repl: migrate to use internal/errors.js #13299

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
5 participants
@sreepurnajasti
Contributor

sreepurnajasti commented May 30, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

lib/internal/repl.js
lib/internal/errors.js

ref: #11273

E('ERR_IPC_CHANNEL_CLOSED', 'channel closed');
E('ERR_IPC_DISCONNECTED', 'IPC channel is already disconnected');
E('ERR_IPC_ONE_PIPE', 'Child process can have only one IPC pipe');
E('ERR_IPC_SYNC_FORK', 'IPC cannot be used with synchronous forks');
E('ERR_MISSING_ARGS', missingArgs);
E('ERR_PARSE_HISTORY_DATA',
(oldHistoryPath) => `Could not parse history data in ${oldHistoryPath}`);

This comment has been minimized.

@jasnell

jasnell May 30, 2017

Member

Just a nit, but it's a bit odd to have one of the new codes use %s while the other uses a template string.

@jasnell

jasnell May 30, 2017

Member

Just a nit, but it's a bit odd to have one of the new codes use %s while the other uses a template string.

This comment has been minimized.

@sreepurnajasti

sreepurnajasti May 31, 2017

Contributor

@jasnell I have used template string. So, do you want me to convert it to %s?

@sreepurnajasti

sreepurnajasti May 31, 2017

Contributor

@jasnell I have used template string. So, do you want me to convert it to %s?

This comment has been minimized.

@jasnell

jasnell May 31, 2017

Member

I would switch the ERR_INVALID_REPL_HISTORY one to use a template string

@jasnell

jasnell May 31, 2017

Member

I would switch the ERR_INVALID_REPL_HISTORY one to use a template string

This comment has been minimized.

@sreepurnajasti

sreepurnajasti Jun 1, 2017

Contributor

@jasnell Done.

@sreepurnajasti

sreepurnajasti Jun 1, 2017

Contributor

@jasnell Done.

Show outdated Hide outdated lib/internal/repl.js Outdated
Show outdated Hide outdated lib/internal/repl.js Outdated
@mhdawson

LGTM

@jasnell

jasnell approved these changes Jun 1, 2017

@jasnell

This comment has been minimized.

Show comment
Hide comment

jasnell added a commit that referenced this pull request Jun 2, 2017

errors,repl: migrate to use internal/errors.js
PR-URL: #13299
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Jun 2, 2017

Member

Landed in 2822796

Member

jasnell commented Jun 2, 2017

Landed in 2822796

@jasnell jasnell closed this Jun 2, 2017

@joyeecheung joyeecheung referenced this pull request Jun 2, 2017

Closed

errors, repl: migrate to use internal/errors.js #11347

4 of 4 tasks complete
@tniessen

This comment has been minimized.

Show comment
Hide comment
@tniessen

tniessen Jun 18, 2017

Member

Too late, but doesn't LGTM. ERR_INVALID_REPL_HISTORY doesn't appear to be used at all. Please review #13733.

Member

tniessen commented Jun 18, 2017

Too late, but doesn't LGTM. ERR_INVALID_REPL_HISTORY doesn't appear to be used at all. Please review #13733.

@tniessen tniessen referenced this pull request Jun 18, 2017

Closed

repl: fix error message #13733

3 of 3 tasks complete

@refack refack added this to Done in Error Codes Aug 20, 2017

@sreepurnajasti sreepurnajasti deleted the sreepurnajasti:repl branch Dec 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment