New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors,http_server: migrate to use internal/errors.js #13301

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
4 participants
@bidipyne
Contributor

bidipyne commented May 30, 2017

Checklist

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

_http_server.js
internal/errors.js

ref: #11273
I read and understood the contribution guidelines, please review and suggest.
@jasnell
Thanks.

Show outdated Hide outdated lib/_http_server.js
Show outdated Hide outdated lib/_http_server.js
Show outdated Hide outdated lib/internal/errors.js
Show outdated Hide outdated lib/internal/errors.js
Show outdated Hide outdated lib/internal/errors.js
Show outdated Hide outdated test/parallel/test-http-response-statuscode.js
Show outdated Hide outdated test/parallel/test-http-write-head.js
@mhdawson

LGTM with a nit

Show outdated Hide outdated lib/_http_server.js
@jasnell

jasnell approved these changes Jun 1, 2017

@jasnell

This comment has been minimized.

Show comment
Hide comment

jasnell added a commit that referenced this pull request Jun 2, 2017

errors,http_server: migrate to use internal/errors.js
PR-URL: #13301
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Jun 2, 2017

Member

Landed in a9f798e

Member

jasnell commented Jun 2, 2017

Landed in a9f798e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment