New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade libuv to 1.12.0 #13306

Merged
merged 3 commits into from Jun 7, 2017

Conversation

@cjihrig
Contributor

cjihrig commented May 30, 2017

If anyone knows of any Node.js issues that are resolved by this release, please link them here so they can be added to the commit metadata, and closed on landing.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

deps

@cjihrig cjihrig requested review from saghul and removed request for saghul May 30, 2017

@BridgeAR

This comment has been minimized.

Show comment
Hide comment
@BridgeAR

BridgeAR May 30, 2017

Member

Solves #12853. As far as I see it, it's the only issue closed by the upgrade.

Member

BridgeAR commented May 30, 2017

Solves #12853. As far as I see it, it's the only issue closed by the upgrade.

Show outdated Hide outdated deps/uv/.github/ISSUE_TEMPLATE.md
@Fishrock123

This comment has been minimized.

Show comment
Hide comment
@Fishrock123

Fishrock123 May 30, 2017

Member

I believe one of the oldest still-open issues, #854, is fixed by this?

Assuming unix: remove FSEventStreamFlushSync() call is in this release.

Member

Fishrock123 commented May 30, 2017

I believe one of the oldest still-open issues, #854, is fixed by this?

Assuming unix: remove FSEventStreamFlushSync() call is in this release.

@bnoordhuis

LGTM

Anyone have opinions on whether to gitignore the uvbook files in docs/code and docs/src/guide? It adds another ~100 kB to the tarball (240 kB uncompressed) and I don't expect many people will look at it.

Important change: this version of libuv raises the minimum supported version from linux 2.6.18 + glibc 2.5 to linux 2.6.32 + glibc 2.12.

The support code for older systems is still there but going forward we won't bend over backwards to keep it in working shape.

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell May 30, 2017

Member

+1 to ignoring the uvbook files

Member

jasnell commented May 30, 2017

+1 to ignoring the uvbook files

@jasnell

Rubber stamp LGTM but I'd like to see a CITGM run before this lands.

@mhdawson

Rubber stamp approval from me as well provided CI passes.

@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Jun 1, 2017

Contributor

@bnoordhuis should the uvbook be explicitly added to .gitignore, or just not checked in?

Contributor

cjihrig commented Jun 1, 2017

@bnoordhuis should the uvbook be explicitly added to .gitignore, or just not checked in?

@bnoordhuis

This comment has been minimized.

Show comment
Hide comment
@bnoordhuis

bnoordhuis Jun 1, 2017

Member

@cjihrig I'd add it to the .gitignore, that prevents accidental check-ins in the future.

Member

bnoordhuis commented Jun 1, 2017

@cjihrig I'd add it to the .gitignore, that prevents accidental check-ins in the future.

@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Jun 1, 2017

Contributor

Removed the uvbook and .github folders. PTAL

Contributor

cjihrig commented Jun 1, 2017

Removed the uvbook and .github folders. PTAL

@richardlau

This comment has been minimized.

Show comment
Hide comment
@richardlau

richardlau Jun 1, 2017

Member

Important change: this version of libuv raises the minimum supported version from linux 2.6.18 + glibc 2.5 to linux 2.6.32 + glibc 2.12.

We should also raise Node.js' minimum supported levels in BUILDING.md to match.

Member

richardlau commented Jun 1, 2017

Important change: this version of libuv raises the minimum supported version from linux 2.6.18 + glibc 2.5 to linux 2.6.32 + glibc 2.12.

We should also raise Node.js' minimum supported levels in BUILDING.md to match.

@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Jun 5, 2017

Contributor

Added a commit to update BUILDING.md.

Contributor

cjihrig commented Jun 5, 2017

Added a commit to update BUILDING.md.

@bnoordhuis

This comment has been minimized.

Show comment
Hide comment
@bnoordhuis

bnoordhuis Jun 5, 2017

Member

Still LGTM. The raised baseline might become non-academic in the future, see libuv/libuv#1372.

Member

bnoordhuis commented Jun 5, 2017

Still LGTM. The raised baseline might become non-academic in the future, see libuv/libuv#1372.

@Fishrock123

This comment has been minimized.

Show comment
Hide comment
@Fishrock123

Fishrock123 Jun 5, 2017

Member

@cjihrig could you please move the .gitignore change into it's own commit?

Member

Fishrock123 commented Jun 5, 2017

@cjihrig could you please move the .gitignore change into it's own commit?

@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig
Contributor

cjihrig commented Jun 5, 2017

@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Jun 5, 2017

Contributor

CI seemed good. Ran CITGM (https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/854/). Can someone help interpreting the output?

Contributor

cjihrig commented Jun 5, 2017

CI seemed good. Ran CITGM (https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/854/). Can someone help interpreting the output?

@gibfahn

This comment has been minimized.

Show comment
Hide comment
@gibfahn
Member

gibfahn commented Jun 5, 2017

@bricss bricss referenced this pull request Jun 5, 2017

Closed

8.1.0 Tracking Issue #13475

cjihrig added some commits May 30, 2017

deps: upgrade libuv to 1.12.0
Fixes: #12853
Fixes: #854
PR-URL: #13306
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
doc: update linux supported versions
The libuv 1.12.0 update bumped the minimum supported version
of linux + glibc. This commit updates BUILDING.md to reflect
the new values.

PR-URL: #13306
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
gitignore: add libuv book and GitHub template
PR-URL: #13306
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

@cjihrig cjihrig merged commit cc8fc46 into nodejs:master Jun 7, 2017

@cjihrig cjihrig deleted the cjihrig:uv branch Jun 7, 2017

jasnell added a commit that referenced this pull request Jun 7, 2017

doc: update linux supported versions
The libuv 1.12.0 update bumped the minimum supported version
of linux + glibc. This commit updates BUILDING.md to reflect
the new values.

PR-URL: #13306
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

jasnell added a commit that referenced this pull request Jun 7, 2017

gitignore: add libuv book and GitHub template
PR-URL: #13306
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

jasnell added a commit to jasnell/node that referenced this pull request Jun 7, 2017

2017-05-07, Version 8.1.0 (Current)
* **Async Hooks**
  * When one `Promise` leads to the creation of a new `Promise`, the parent
    `Promise` will be identified as the trigger
    [[`135f4e6643`](nodejs@135f4e6)]
    [#13367](nodejs#13367).
* **Dependencies**
  * libuv has been updated to 1.12.0
    [[`968596ec77`](nodejs@968596e)]
    [#13306](nodejs#13306).
  * npm has been updated to 5.0.3
    [[`ffa7debd7a`](nodejs@ffa7deb)]
    [#13487](nodejs#13487).
* **File system**
  * The `fs.exists()` function now works correctly with `util.promisify()`
    [[`6e0eccd7a1`](nodejs@6e0eccd)]
    [#13316](nodejs#13316).
  * fs.Stats times are now also available as numbers
    [[`c756efb25a`](nodejs@c756efb)]
    [#13173](nodejs#13173).
* **Inspector**
  * It is now possible to bind to a random port using `--inspect=0`
    [[`cc6ec2fb27`](nodejs@cc6ec2f)]
    [#5025](nodejs#5025).
* **Zlib**
  * A regression in the Zlib module that made it impossible to properly
    subclasses `zlib.Deflate` and other Zlib classes has been fixed.
    [[`6aeb555cc4`](nodejs@6aeb555)]
    [#13374](nodejs#13374).

rvagg added a commit that referenced this pull request Jun 8, 2017

2017-05-07, Version 8.1.0 (Current)
* **Async Hooks**
  * When one `Promise` leads to the creation of a new `Promise`, the parent
    `Promise` will be identified as the trigger
    [[`135f4e6643`](135f4e6)]
    [#13367](#13367).
* **Dependencies**
  * libuv has been updated to 1.12.0
    [[`968596ec77`](968596e)]
    [#13306](#13306).
  * npm has been updated to 5.0.3
    [[`ffa7debd7a`](ffa7deb)]
    [#13487](#13487).
* **File system**
  * The `fs.exists()` function now works correctly with `util.promisify()`
    [[`6e0eccd7a1`](6e0eccd)]
    [#13316](#13316).
  * fs.Stats times are now also available as numbers
    [[`c756efb25a`](c756efb)]
    [#13173](#13173).
* **Inspector**
  * It is now possible to bind to a random port using `--inspect=0`
    [[`cc6ec2fb27`](cc6ec2f)]
    [#5025](#5025).
* **Zlib**
  * A regression in the Zlib module that made it impossible to properly
    subclasses `zlib.Deflate` and other Zlib classes has been fixed.
    [[`6aeb555cc4`](6aeb555)]
    [#13374](#13374).

rvagg added a commit that referenced this pull request Jun 8, 2017

2017-05-07, Version 8.1.0 (Current)
* **Async Hooks**
  * When one `Promise` leads to the creation of a new `Promise`, the parent
    `Promise` will be identified as the trigger
    [[`135f4e6643`](135f4e6)]
    [#13367](#13367).
* **Dependencies**
  * libuv has been updated to 1.12.0
    [[`968596ec77`](968596e)]
    [#13306](#13306).
  * npm has been updated to 5.0.3
    [[`ffa7debd7a`](ffa7deb)]
    [#13487](#13487).
* **File system**
  * The `fs.exists()` function now works correctly with `util.promisify()`
    [[`6e0eccd7a1`](6e0eccd)]
    [#13316](#13316).
  * fs.Stats times are now also available as numbers
    [[`c756efb25a`](c756efb)]
    [#13173](#13173).
* **Inspector**
  * It is now possible to bind to a random port using `--inspect=0`
    [[`cc6ec2fb27`](cc6ec2f)]
    [#5025](#5025).
* **Zlib**
  * A regression in the Zlib module that made it impossible to properly
    subclasses `zlib.Deflate` and other Zlib classes has been fixed.
    [[`6aeb555cc4`](6aeb555)]
    [#13374](#13374).

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete
@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Jul 17, 2017

Member

Can we get this backported to v6.x for a future semver minor

Member

MylesBorins commented Jul 17, 2017

Can we get this backported to v6.x for a future semver minor

@bnoordhuis bnoordhuis referenced this pull request Aug 16, 2017

Merged

deps: upgrade libuv to 1.13.1 #14117

2 of 2 tasks complete
@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Sep 19, 2017

Member

@cjihrig @bnoordhuis do you see any issues with backporting this to v6.x? The minimal version of kernel + libc are slightly worrysome, but your comments appear to imply that it isn't a big deal.

Member

MylesBorins commented Sep 19, 2017

@cjihrig @bnoordhuis do you see any issues with backporting this to v6.x? The minimal version of kernel + libc are slightly worrysome, but your comments appear to imply that it isn't a big deal.

@gibfahn

This comment has been minimized.

Show comment
Hide comment
@gibfahn

gibfahn Sep 19, 2017

Member

Could we backport this version without backporting the supported versions update? @bnoordhuis you mentioned that it was academic for this release, and this is likely to be the last libuv update for 6.x.

Member

gibfahn commented Sep 19, 2017

Could we backport this version without backporting the supported versions update? @bnoordhuis you mentioned that it was academic for this release, and this is likely to be the last libuv update for 6.x.

@bnoordhuis

This comment has been minimized.

Show comment
Hide comment
@bnoordhuis

bnoordhuis Sep 19, 2017

Member

None of the support code for old kernels was removed so yes, this is safe to back-port.

Member

bnoordhuis commented Sep 19, 2017

None of the support code for old kernels was removed so yes, this is safe to back-port.

MylesBorins added a commit that referenced this pull request Oct 16, 2017

deps: upgrade libuv to 1.12.0
Fixes: #12853
Fixes: #854
PR-URL: #13306
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

MylesBorins added a commit that referenced this pull request Oct 16, 2017

gitignore: add libuv book and GitHub template
PR-URL: #13306
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

@cjihrig cjihrig referenced this pull request Oct 16, 2017

Merged

deps: upgrade libuv to 1.15.0 #15745

2 of 2 tasks complete

@MylesBorins MylesBorins referenced this pull request Oct 17, 2017

Merged

v6.12.0 proposal #16263

MylesBorins added a commit that referenced this pull request Oct 25, 2017

deps: upgrade libuv to 1.12.0
Fixes: #12853
Fixes: #854
PR-URL: #13306
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

MylesBorins added a commit that referenced this pull request Oct 25, 2017

gitignore: add libuv book and GitHub template
PR-URL: #13306
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

@MylesBorins MylesBorins referenced this pull request Nov 3, 2017

Merged

v4.8.6 proposal #16500

MylesBorins added a commit that referenced this pull request Nov 6, 2017

2017-11-07, Version 6.12.0 'Boron' (LTS)
Notable Changes:

* assert:
  - assert.fail() can now take one or two arguments (Rich Trott)
    #12293
* crypto:
  - add sign/verify support for RSASSA-PSS (Tobias Nießen)
    #11705
* deps:
  - upgrade openssl sources to 1.0.2m (Shigeki Ohtsu)
    #16691
  - upgrade libuv to 1.15.0 (cjihrig)
    #15745
  - upgrade libuv to 1.14.1 (cjihrig)
    #14866
  - upgrade libuv to 1.13.1 (cjihrig)
    #14117
  - upgrade libuv to 1.12.0 (cjihrig)
    #13306
* fs:
  - Add support for fs.write/fs.writeSync(fd, buffer, cb) and
    fs.write/fs.writeSync(fd, buffer, offset, cb) as documented
    (Andreas Lind) #7856
* inspector:
  - enable --inspect-brk (Refael Ackermann)
    #12615
* process:
  - add --redirect-warnings command line argument (James M Snell)
    #10116
* src:
  - allow CLI args in env with NODE_OPTIONS (Sam Roberts)
    #12028)
  - --abort-on-uncaught-exception in NODE_OPTIONS (Sam Roberts)
    #13932
  - allow --tls-cipher-list in NODE_OPTIONS (Sam Roberts)
    #13172
  - use SafeGetenv() for NODE_REDIRECT_WARNINGS (Sam Roberts)
    #12677
* test:
  - remove common.fail() (Rich Trott)
    #12293

PR-URL: #16263

MylesBorins added a commit that referenced this pull request Nov 7, 2017

2017-11-07, Version 6.12.0 'Boron' (LTS)
Notable Changes:

* assert:
  - assert.fail() can now take one or two arguments (Rich Trott)
    #12293
* crypto:
  - add sign/verify support for RSASSA-PSS (Tobias Nießen)
    #11705
* deps:
  - upgrade openssl sources to 1.0.2m (Shigeki Ohtsu)
    #16691
  - upgrade libuv to 1.15.0 (cjihrig)
    #15745
  - upgrade libuv to 1.14.1 (cjihrig)
    #14866
  - upgrade libuv to 1.13.1 (cjihrig)
    #14117
  - upgrade libuv to 1.12.0 (cjihrig)
    #13306
* fs:
  - Add support for fs.write/fs.writeSync(fd, buffer, cb) and
    fs.write/fs.writeSync(fd, buffer, offset, cb) as documented
    (Andreas Lind) #7856
* inspector:
  - enable --inspect-brk (Refael Ackermann)
    #12615
* process:
  - add --redirect-warnings command line argument (James M Snell)
    #10116
* src:
  - allow CLI args in env with NODE_OPTIONS (Sam Roberts)
    #12028)
  - --abort-on-uncaught-exception in NODE_OPTIONS (Sam Roberts)
    #13932
  - allow --tls-cipher-list in NODE_OPTIONS (Sam Roberts)
    #13172
  - use SafeGetenv() for NODE_REDIRECT_WARNINGS (Sam Roberts)
    #12677
* test:
  - remove common.fail() (Rich Trott)
    #12293

PR-URL: #16263

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

2017-11-07, Version 6.12.0 'Boron' (LTS)
Notable Changes:

* assert:
  - assert.fail() can now take one or two arguments (Rich Trott)
    nodejs#12293
* crypto:
  - add sign/verify support for RSASSA-PSS (Tobias Nießen)
    nodejs#11705
* deps:
  - upgrade openssl sources to 1.0.2m (Shigeki Ohtsu)
    nodejs#16691
  - upgrade libuv to 1.15.0 (cjihrig)
    nodejs#15745
  - upgrade libuv to 1.14.1 (cjihrig)
    nodejs#14866
  - upgrade libuv to 1.13.1 (cjihrig)
    nodejs#14117
  - upgrade libuv to 1.12.0 (cjihrig)
    nodejs#13306
* fs:
  - Add support for fs.write/fs.writeSync(fd, buffer, cb) and
    fs.write/fs.writeSync(fd, buffer, offset, cb) as documented
    (Andreas Lind) nodejs#7856
* inspector:
  - enable --inspect-brk (Refael Ackermann)
    nodejs#12615
* process:
  - add --redirect-warnings command line argument (James M Snell)
    nodejs#10116
* src:
  - allow CLI args in env with NODE_OPTIONS (Sam Roberts)
    nodejs#12028)
  - --abort-on-uncaught-exception in NODE_OPTIONS (Sam Roberts)
    nodejs#13932
  - allow --tls-cipher-list in NODE_OPTIONS (Sam Roberts)
    nodejs#13172
  - use SafeGetenv() for NODE_REDIRECT_WARNINGS (Sam Roberts)
    nodejs#12677
* test:
  - remove common.fail() (Rich Trott)
    nodejs#12293

PR-URL: nodejs#16263
@uttampawar

This comment has been minimized.

Show comment
Hide comment
@uttampawar

uttampawar Jun 14, 2018

Contributor

Is there a timeline when this can land? Thanks.

Contributor

uttampawar commented Jun 14, 2018

Is there a timeline when this can land? Thanks.

@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Jun 14, 2018

Contributor

Land where? Node 6 is the oldest supported release line and it has a newer version of libuv than this.

Contributor

cjihrig commented Jun 14, 2018

Land where? Node 6 is the oldest supported release line and it has a newer version of libuv than this.

@uttampawar

This comment has been minimized.

Show comment
Hide comment
@uttampawar

uttampawar Jun 15, 2018

Contributor

@cjihrig I thought that content of libuv/libuv#1372 is getting pulled in as part of this PR which I realized is not the case. I apologize for the confusion, it was misunderstanding on my part.

Contributor

uttampawar commented Jun 15, 2018

@cjihrig I thought that content of libuv/libuv#1372 is getting pulled in as part of this PR which I realized is not the case. I apologize for the confusion, it was misunderstanding on my part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment