New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors,stream-transform: migrate to use internal/errors.js #13310

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
7 participants
@sreepurnajasti
Contributor

sreepurnajasti commented May 30, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

lib/_stream_transform.js

ref: #11273

Show outdated Hide outdated lib/_stream_transform.js Outdated
Show outdated Hide outdated test/parallel/test-stream-transform-callback-twice.js Outdated
Show outdated Hide outdated lib/internal/errors.js Outdated
@kunalspathak

This comment has been minimized.

Show comment
Hide comment
@kunalspathak

kunalspathak May 31, 2017

Contributor

@sreepurnajasti - Changes incorporated from my feedback looks good although I kind of don't like ERR_CALLING_WS_LENGTH as the reader doesn't easily get the intent of the error message. I will leave it to @jasnell to comment on this.

Contributor

kunalspathak commented May 31, 2017

@sreepurnajasti - Changes incorporated from my feedback looks good although I kind of don't like ERR_CALLING_WS_LENGTH as the reader doesn't easily get the intent of the error message. I will leave it to @jasnell to comment on this.

Show outdated Hide outdated lib/_stream_transform.js Outdated
Show outdated Hide outdated lib/_stream_transform.js Outdated
Show outdated Hide outdated lib/_stream_transform.js Outdated
@sreepurnajasti

This comment has been minimized.

Show comment
Hide comment
@sreepurnajasti

sreepurnajasti Jun 12, 2017

Contributor

@mhdawson @jasnell As per the suggestions, it is modified. Please, have a look.

Contributor

sreepurnajasti commented Jun 12, 2017

@mhdawson @jasnell As per the suggestions, it is modified. Please, have a look.

@mhdawson

This comment has been minimized.

Show comment
Hide comment
Member

mhdawson commented Jun 14, 2017

@mhdawson

This comment has been minimized.

Show comment
Hide comment
@mhdawson

mhdawson Jun 15, 2017

Member

CI good landing

Member

mhdawson commented Jun 15, 2017

CI good landing

@mhdawson

This comment has been minimized.

Show comment
Hide comment
@mhdawson

mhdawson Jun 15, 2017

Member

Landed as d50a802

Member

mhdawson commented Jun 15, 2017

Landed as d50a802

mhdawson added a commit that referenced this pull request Jun 15, 2017

errors,stream-transform: migrate to use internal/errors.js
PR-URL: #13310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

@TimothyGu TimothyGu closed this Jun 15, 2017

@sreepurnajasti

This comment has been minimized.

Show comment
Hide comment
@sreepurnajasti

sreepurnajasti Jun 18, 2017

Contributor

@mhdawson Thank you :)

Contributor

sreepurnajasti commented Jun 18, 2017

@mhdawson Thank you :)

@mcollina

This comment has been minimized.

Show comment
Hide comment
@mcollina

mcollina Jun 21, 2017

Member

I'm strongly -1 on this one. This forces some good rework on readable-stream to pull those error data. May I ask for a revert?

cc @nodejs/streams

Member

mcollina commented Jun 21, 2017

I'm strongly -1 on this one. This forces some good rework on readable-stream to pull those error data. May I ask for a revert?

cc @nodejs/streams

@mcollina

This comment has been minimized.

Show comment
Hide comment
@mcollina

mcollina Jun 21, 2017

Member

To be clear, this is something we should be doing asap, but we need to think a bit how we want to do it.

Member

mcollina commented Jun 21, 2017

To be clear, this is something we should be doing asap, but we need to think a bit how we want to do it.

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Jun 21, 2017

Member

:-/ ... reverting would be unfortunate. Perhaps instead, since this is semver-major and won't go out in a release any time soon, can we take a short bit of time to figure out the strategy for readable-stream? And if we can't identify a reasonable path forward, then revert...

Member

jasnell commented Jun 21, 2017

:-/ ... reverting would be unfortunate. Perhaps instead, since this is semver-major and won't go out in a release any time soon, can we take a short bit of time to figure out the strategy for readable-stream? And if we can't identify a reasonable path forward, then revert...

@mcollina

This comment has been minimized.

Show comment
Hide comment
@mcollina

mcollina Jun 21, 2017

Member

That's ok for me, there is no hurry to revert.

Member

mcollina commented Jun 21, 2017

That's ok for me, there is no hurry to revert.

@refack refack added this to Done in Error Codes Aug 20, 2017

@sreepurnajasti sreepurnajasti deleted the sreepurnajasti:stream-transform branch Dec 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment