New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix typos in n-api.md #13323

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants
@disjukr
Contributor

disjukr commented May 31, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

I think this is just typo

@lpinca

lpinca approved these changes May 31, 2017

@lpinca

This comment has been minimized.

Show comment
Hide comment
@lpinca

lpinca May 31, 2017

Member

I think this doesn't need to wait the full 48 hours.

Member

lpinca commented May 31, 2017

I think this doesn't need to wait the full 48 hours.

@vsemozhetbyt

This comment has been minimized.

Show comment
Hide comment
@vsemozhetbyt

vsemozhetbyt May 31, 2017

Member

Landed in fd54b10

Thank you, @disjukr!

Member

vsemozhetbyt commented May 31, 2017

Landed in fd54b10

Thank you, @disjukr!

vsemozhetbyt added a commit that referenced this pull request May 31, 2017

doc: fix typo in n-api.md
PR-URL: #13323
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@disjukr disjukr deleted the disjukr:doc-types branch May 31, 2017

jasnell added a commit that referenced this pull request Jun 5, 2017

doc: fix typo in n-api.md
PR-URL: #13323
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@jasnell jasnell referenced this pull request Jun 5, 2017

Closed

8.1.0 Proposal #13483

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Mar 12, 2018

doc: fix typo in n-api.md
PR-URL: nodejs#13323
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Mar 15, 2018

doc: fix typo in n-api.md
PR-URL: nodejs#13323
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Mar 31, 2018

doc: fix typo in n-api.md
PR-URL: nodejs#13323
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Apr 6, 2018

doc: fix typo in n-api.md
PR-URL: nodejs#13323
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Apr 10, 2018

doc: fix typo in n-api.md
PR-URL: nodejs#13323
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins added a commit that referenced this pull request Apr 16, 2018

doc: fix typo in n-api.md
Backport-PR-URL: #19447
PR-URL: #13323
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@MylesBorins MylesBorins referenced this pull request Apr 16, 2018

Merged

v6.14.2 proposal #19996

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment