New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: added mips64el to valid_arch #13620

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
9 participants
@thelostone-mc
Contributor

thelostone-mc commented Jun 11, 2017

Fixes: #13616

configure: add mips64el to valid_arch

Files Changed

  • configure
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)
@gibfahn

This comment has been minimized.

Show comment
Hide comment
@gibfahn

gibfahn Jun 11, 2017

Member

Could you change your commit message to:

configure: add mips64el to valid_arch

Fixes: https://github.com/nodejs/node/issues/13616

(as per the Contributing Guidelines)?

If you don't have time it can be rewritten by whoever lands this.

Member

gibfahn commented Jun 11, 2017

Could you change your commit message to:

configure: add mips64el to valid_arch

Fixes: https://github.com/nodejs/node/issues/13616

(as per the Contributing Guidelines)?

If you don't have time it can be rewritten by whoever lands this.

@gibfahn

This comment has been minimized.

Show comment
Hide comment
@gibfahn
Member

gibfahn commented Jun 11, 2017

@gibfahn gibfahn added the mips label Jun 11, 2017

@refack

refack approved these changes Jun 12, 2017

Show outdated Hide outdated configure
@refack

refack approved these changes Jun 12, 2017

💯

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack Jun 12, 2017

Member

/cc @nodejs/lts original issue was about the v6.x branch...

Member

refack commented Jun 12, 2017

/cc @nodejs/lts original issue was about the v6.x branch...

@gibfahn

This comment has been minimized.

Show comment
Hide comment
@gibfahn

gibfahn Jun 12, 2017

Member

original issue was about the v6.x branch...

I think we can follow our standard backporting procedure on this, so we'll land in master and include in the next v6.x release (or the one after).

Member

gibfahn commented Jun 12, 2017

original issue was about the v6.x branch...

I think we can follow our standard backporting procedure on this, so we'll land in master and include in the next v6.x release (or the one after).

jasnell added a commit that referenced this pull request Jun 13, 2017

configure: add mips64el to valid_arch
PR-URL: #13620
Fixes: #13616
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Jun 13, 2017

Member

Landed in 224dbb1

Member

jasnell commented Jun 13, 2017

Landed in 224dbb1

@jasnell jasnell closed this Jun 13, 2017

addaleax added a commit that referenced this pull request Jun 17, 2017

configure: add mips64el to valid_arch
PR-URL: #13620
Fixes: #13616
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

addaleax added a commit that referenced this pull request Jun 17, 2017

configure: add mips64el to valid_arch
PR-URL: #13620
Fixes: #13616
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

@addaleax addaleax referenced this pull request Jun 17, 2017

Merged

v8.2.0 proposal #13744

addaleax added a commit that referenced this pull request Jun 21, 2017

configure: add mips64el to valid_arch
PR-URL: #13620
Fixes: #13616
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

@addaleax addaleax referenced this pull request Jun 21, 2017

Merged

v8.1.3 proposal #13861

MylesBorins added a commit that referenced this pull request Jul 17, 2017

configure: add mips64el to valid_arch
PR-URL: #13620
Fixes: #13616
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

@MylesBorins MylesBorins referenced this pull request Jul 18, 2017

Merged

v6.11.2 proposal #14356

MylesBorins added a commit that referenced this pull request Aug 1, 2017

2017-08-01, Version 6.11.2 'Boron' (LTS)
This LTS release comes with 221 commits. This includes 80 which are
test related, 52 which are doc related, 32 which are build / tool
related and 10 commits which are updates to dependencies.

Notable Changes:

* configure:
  - add mips64el to valid_arch (Aditya Anand)
    - #13620
* crypto:
  - Updated root certificates based on [NSS 3.30] (Ben Noordhuis)
    - #13279
    - #12402
    - https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/NSS_3.30_release_notes
* deps:
  - upgrade OpenSSL to version 1.0.2.l (Shigeki Ohtsu)
    - #12913
* http:
  - parse errors are now reported when NODE_DEBUG=http (Sam Roberts)
    - #13206
  - Agent construction can now be envoked without `new` (cjihrig)
    - #12927
* zlib:
  - node will now throw an Error when zlib rejects the value of windowBits,
    instead of crashing (Alexey Orlenko)
    - #13098

PR-URL: #14356

MylesBorins added a commit that referenced this pull request Aug 1, 2017

2017-08-01, Version 6.11.2 'Boron' (LTS)
This LTS release comes with 221 commits. This includes 80 which are
test related, 52 which are doc related, 32 which are build / tool
related and 10 commits which are updates to dependencies.

Notable Changes:

* configure:
  - add mips64el to valid_arch (Aditya Anand)
    - #13620
* crypto:
  - Updated root certificates based on [NSS 3.30] (Ben Noordhuis)
    - #13279
    - #12402
    - https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/NSS_3.30_release_notes
* deps:
  - upgrade OpenSSL to version 1.0.2.l (Shigeki Ohtsu)
    - #12913
* http:
  - parse errors are now reported when NODE_DEBUG=http (Sam Roberts)
    - #13206
  - Agent construction can now be envoked without `new` (cjihrig)
    - #12927
* zlib:
  - node will now throw an Error when zlib rejects the value of windowBits,
    instead of crashing (Alexey Orlenko)
    - #13098

PR-URL: #14356
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment