New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: check zlib version for createDeflateRaw #13697

Closed
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
@danbev
Member

danbev commented Jun 15, 2017

We are currenly builing Node with --shared-zlib which happens to be
version 1.2.8. The test for zlib.createDeflateRaw is expected to fail
but does not when using version 1.2.8.

As far as I can tell the fix referred to in the comments was
introduced in version 1.2.9:

- Reject a window size of 256 bytes if not using the zlib wrapper

This commit suggests adding a check for the version and skipping this
assert if the version is less than 1.2.9.

Refs: http://zlib.net/ChangeLog.txt

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

test: check zlib version for createDeflateRaw
We are currenly builing Node with --shared-zlib which happens to be
version 1.2.8. The test for zlib.createDeflateRaw is expected to fail
but does not when using version 1.2.8.

As far as I can tell the fix referred to in the comments was
introduced in version 1.2.9:
- Reject a window size of 256 bytes if not using the zlib wrapper

This commit suggests adding a check for the version and skipping this
assert if the version is less than 1.2.9.

Refs: http://zlib.net/ChangeLog.txt
@danbev

This comment has been minimized.

Show comment
Hide comment
@danbev

This comment has been minimized.

Show comment
Hide comment
@danbev

danbev Jun 15, 2017

Member
test/osx failure looks unrelated

console output:

not ok 168 async-hooks/test-callback-error
  ---
  duration_ms: 60.87
  severity: fail
  stack: |-
    timeout
Member

danbev commented Jun 15, 2017

test/osx failure looks unrelated

console output:

not ok 168 async-hooks/test-callback-error
  ---
  duration_ms: 60.87
  severity: fail
  stack: |-
    timeout

@mscdex mscdex added the zlib label Jun 15, 2017

Show outdated Hide outdated test/parallel/test-zlib-failed-init.js
@danbev

This comment has been minimized.

Show comment
Hide comment
@danbev

danbev Jun 15, 2017

Member

Could you use test() instead of match()

No problem, I'll change this.

Member

danbev commented Jun 15, 2017

Could you use test() instead of match()

No problem, I'll change this.

@jasnell

LGTM once the comment is added.

@lpinca

lpinca approved these changes Jun 16, 2017

@danbev

This comment has been minimized.

Show comment
Hide comment
@richardlau

LGTM with one nit.

Show outdated Hide outdated test/parallel/test-zlib-failed-init.js

danbev added a commit to danbev/node that referenced this pull request Jun 18, 2017

test: check zlib version for createDeflateRaw
We are currenly builing Node with --shared-zlib which happens to be
version 1.2.8. The test for zlib.createDeflateRaw is expected to fail
but does not when using version 1.2.8.

As far as I can tell the fix referred to in the comments was
introduced in version 1.2.9:
- Reject a window size of 256 bytes if not using the zlib wrapper

This commit suggests adding a check for the version and skipping this
assert if the version is less than 1.2.9.

Refs: http://zlib.net/ChangeLog.txt
PR-URL: nodejs#13697
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@danbev

This comment has been minimized.

Show comment
Hide comment
@danbev

danbev Jun 18, 2017

Member

Landed in 5189857

Member

danbev commented Jun 18, 2017

Landed in 5189857

@danbev danbev closed this Jun 18, 2017

addaleax added a commit that referenced this pull request Jun 20, 2017

test: check zlib version for createDeflateRaw
We are currenly builing Node with --shared-zlib which happens to be
version 1.2.8. The test for zlib.createDeflateRaw is expected to fail
but does not when using version 1.2.8.

As far as I can tell the fix referred to in the comments was
introduced in version 1.2.9:
- Reject a window size of 256 bytes if not using the zlib wrapper

This commit suggests adding a check for the version and skipping this
assert if the version is less than 1.2.9.

Refs: http://zlib.net/ChangeLog.txt
PR-URL: #13697
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

@addaleax addaleax referenced this pull request Jun 21, 2017

Merged

v8.2.0 proposal #13744

addaleax added a commit that referenced this pull request Jun 21, 2017

test: check zlib version for createDeflateRaw
We are currenly builing Node with --shared-zlib which happens to be
version 1.2.8. The test for zlib.createDeflateRaw is expected to fail
but does not when using version 1.2.8.

As far as I can tell the fix referred to in the comments was
introduced in version 1.2.9:
- Reject a window size of 256 bytes if not using the zlib wrapper

This commit suggests adding a check for the version and skipping this
assert if the version is less than 1.2.9.

Refs: http://zlib.net/ChangeLog.txt
PR-URL: #13697
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

@addaleax addaleax referenced this pull request Jun 21, 2017

Merged

v8.1.3 proposal #13861

@danbev danbev deleted the danbev:zlib-version-check-test branch Jun 28, 2017

@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Jul 17, 2017

Member

should this be backported to v6.x?

Member

MylesBorins commented Jul 17, 2017

should this be backported to v6.x?

@danbev

This comment has been minimized.

Show comment
Hide comment
@danbev

danbev Aug 15, 2017

Member

should this be backported to v6.x?

I don't think this needs to be backported. Sorry again about the late/missed reply on this.

Member

danbev commented Aug 15, 2017

should this be backported to v6.x?

I don't think this needs to be backported. Sorry again about the late/missed reply on this.

@drewfish

This comment has been minimized.

Show comment
Hide comment
@drewfish

drewfish Sep 13, 2017

Contributor

BTW here at Yahoo we just backported this to our internal v6.x branch, since we ./configure --shared-zlib with an older version of zlib.

Contributor

drewfish commented Sep 13, 2017

BTW here at Yahoo we just backported this to our internal v6.x branch, since we ./configure --shared-zlib with an older version of zlib.

@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Sep 14, 2017

Member

@drewfish would you be willing to submit your patch as a backport to v6.x-staging? There are a ton of conflicts rn, but I'm sure we would be willing to land it so you don't need to float it.

Also fwiw... if you are floating any other patches on 6.x please feel free to open an issue on https://github.com/nodejs/lts for us to take a look

Member

MylesBorins commented Sep 14, 2017

@drewfish would you be willing to submit your patch as a backport to v6.x-staging? There are a ton of conflicts rn, but I'm sure we would be willing to land it so you don't need to float it.

Also fwiw... if you are floating any other patches on 6.x please feel free to open an issue on https://github.com/nodejs/lts for us to take a look

@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins
Member

MylesBorins commented Sep 19, 2017

ping @drewfish

drewfish added a commit to drewfish/node that referenced this pull request Sep 19, 2017

test: older shared zlib doesnt throw on create
When using compiling using `./configure --shared-zlib` older versions
of the shared zlib might not through as expected by the
test-zlib-failed-init test.

Refs: nodejs#13697
@drewfish

This comment has been minimized.

Show comment
Hide comment
@drewfish

drewfish Sep 19, 2017

Contributor

pong #15478

Contributor

drewfish commented Sep 19, 2017

pong #15478

drewfish added a commit to drewfish/node that referenced this pull request Sep 19, 2017

test: older shared zlib doesnt throw on create
When using compiling using `./configure --shared-zlib` older versions
of the shared zlib might not through as expected by the
test-zlib-failed-init test.

Refs: nodejs#13697

drewfish added a commit to drewfish/node that referenced this pull request Sep 20, 2017

test: older shared zlib doesnt throw on create
When using compiling using `./configure --shared-zlib` older versions
of the shared zlib might not through as expected by the
test-zlib-failed-init test.

Refs: nodejs#13697

MylesBorins added a commit that referenced this pull request Sep 22, 2017

test: check zlib version for createDeflateRaw
We are currenly builing Node with --shared-zlib which happens to be
version 1.2.8. The test for zlib.createDeflateRaw is expected to fail
but does not when using version 1.2.8.

As far as I can tell the fix referred to in the comments was
introduced in version 1.2.9:
- Reject a window size of 256 bytes if not using the zlib wrapper

This commit suggests adding a check for the version and skipping this
assert if the version is less than 1.2.9.

Refs: http://zlib.net/ChangeLog.txt
Backport-PR-URL: #15478
PR-URL: #13697
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

@MylesBorins MylesBorins referenced this pull request Sep 22, 2017

Merged

v6.11.4 proposal #15506

MylesBorins added a commit that referenced this pull request Sep 26, 2017

test: check zlib version for createDeflateRaw
We are currenly builing Node with --shared-zlib which happens to be
version 1.2.8. The test for zlib.createDeflateRaw is expected to fail
but does not when using version 1.2.8.

As far as I can tell the fix referred to in the comments was
introduced in version 1.2.9:
- Reject a window size of 256 bytes if not using the zlib wrapper

This commit suggests adding a check for the version and skipping this
assert if the version is less than 1.2.9.

Refs: http://zlib.net/ChangeLog.txt
Backport-PR-URL: #15478
PR-URL: #13697
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment