New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: fix `undefined` in Readable object mode #13760

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
6 participants
@addaleax
Member

addaleax commented Jun 18, 2017

Fixes this.push(undefined).

Fixes: #13753

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

stream

/cc @nodejs/streams

stream: fix `undefined` in Readable object mode
Fixes `this.push(undefined)`.

Fixes: #13753
@mcollina

LGTM if CI is green.

@addaleax

This comment has been minimized.

Show comment
Hide comment
@tniessen

This comment has been minimized.

Show comment
Hide comment
@tniessen

tniessen Jun 18, 2017

Member

CI failure is unrelated, see #13527.

Member

tniessen commented Jun 18, 2017

CI failure is unrelated, see #13527.

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Jun 21, 2017

Member

Landed in 9a655e9

Member

addaleax commented Jun 21, 2017

Landed in 9a655e9

@addaleax addaleax closed this Jun 21, 2017

@addaleax addaleax deleted the addaleax:stream-fix-undefined branch Jun 21, 2017

addaleax added a commit that referenced this pull request Jun 21, 2017

stream: fix `undefined` in Readable object mode
Fixes `this.push(undefined)`.

Fixes: #13753
PR-URL: #13760
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Calvin Metcalf <calvin.metcalf@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

@addaleax addaleax referenced this pull request Jun 21, 2017

Merged

v8.2.0 proposal #13744

addaleax added a commit that referenced this pull request Jun 21, 2017

stream: fix `undefined` in Readable object mode
Fixes `this.push(undefined)`.

Fixes: #13753
PR-URL: #13760
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Calvin Metcalf <calvin.metcalf@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

@addaleax addaleax referenced this pull request Jun 21, 2017

Merged

v8.1.3 proposal #13861

addaleax added a commit that referenced this pull request Jun 24, 2017

2017-06-??, Version 8.1.3 (Current)
Notable changes

* **Stream**
  Two regressions with the `stream` module have been fixed:
  * The `finish` event will now always be emitted after the `error` event
    if one is emitted:
    [[`0a9e96e86c`](0a9e96e)]
    [#13850](#13850)
  * In object mode, readable streams can now use `undefined` again.
    [[`5840138e70`](5840138)]
    [#13760](#13760)

rvagg added a commit that referenced this pull request Jun 29, 2017

2017-06-29, Version 8.1.3 (Current)
Notable changes

* **Stream**
  Two regressions with the `stream` module have been fixed:
  * The `finish` event will now always be emitted after the `error` event
    if one is emitted:
    [[`0a9e96e86c`](0a9e96e)]
    [#13850](#13850)
  * In object mode, readable streams can now use `undefined` again.
    [[`5840138e70`](5840138)]
    [#13760](#13760)

rvagg added a commit that referenced this pull request Jun 29, 2017

2017-06-29, Version 8.1.3 (Current)
Notable changes

* **Stream**
  Two regressions with the `stream` module have been fixed:
  * The `finish` event will now always be emitted after the `error` event
    if one is emitted:
    [[`0a9e96e86c`](0a9e96e)]
    [#13850](#13850)
  * In object mode, readable streams can now use `undefined` again.
    [[`5840138e70`](5840138)]
    [#13760](#13760)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment