New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: doc lifetime of n-api last error info #13939

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
7 participants
@mhdawson
Member

mhdawson commented Jun 26, 2017

Document the lifetime of the structure returned
by napi_get_last_error_info

Fixes: nodejs/abi-stable-node#251

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc, n-api

doc: doc lifetime of n-api last error info
Document the lifetime of the structure returned
by napi_get_last_error_info

Fixes: nodejs/abi-stable-node#251
@@ -269,6 +269,9 @@ Returns `napi_ok` if the API succeeded.
This API retrieves a `napi_extended_error_info` structure with information
about the last error that occurred.
*Note*: The content of the 'napi_extended_error_info` returned is only

This comment has been minimized.

@vsemozhetbyt

vsemozhetbyt Jun 26, 2017

Member

Wrong quote before napi_?

This comment has been minimized.

@mhdawson

mhdawson Jun 27, 2017

Member

Thanks ! Pushed commit to fix.

@digitalinfinity

I see the same issue as @vsemozhetbyt - other than that LGTM

@cjihrig

LGTM with the quote nit addressed.

@mhdawson

This comment has been minimized.

Member

mhdawson commented Jun 28, 2017

@mhdawson

This comment has been minimized.

Member

mhdawson commented Jun 28, 2017

CI good landing.

@mhdawson

This comment has been minimized.

Member

mhdawson commented Jun 28, 2017

Landed as ef28d85

@mhdawson mhdawson closed this Jun 28, 2017

mhdawson added a commit that referenced this pull request Jun 28, 2017

doc: doc lifetime of n-api last error info
Document the lifetime of the structure returned
by napi_get_last_error_info

PR-URL: #13939
Fixes: nodejs/abi-stable-node#251
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>

addaleax added a commit that referenced this pull request Jun 29, 2017

doc: doc lifetime of n-api last error info
Document the lifetime of the structure returned
by napi_get_last_error_info

PR-URL: #13939
Fixes: nodejs/abi-stable-node#251
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>

@addaleax addaleax referenced this pull request Jun 29, 2017

Merged

v8.2.0 proposal #13744

addaleax added a commit that referenced this pull request Jul 11, 2017

doc: doc lifetime of n-api last error info
Document the lifetime of the structure returned
by napi_get_last_error_info

PR-URL: #13939
Fixes: nodejs/abi-stable-node#251
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>

addaleax added a commit that referenced this pull request Jul 18, 2017

doc: doc lifetime of n-api last error info
Document the lifetime of the structure returned
by napi_get_last_error_info

PR-URL: #13939
Fixes: nodejs/abi-stable-node#251
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Mar 12, 2018

doc: doc lifetime of n-api last error info
Document the lifetime of the structure returned
by napi_get_last_error_info

PR-URL: nodejs#13939
Fixes: nodejs/abi-stable-node#251
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Mar 15, 2018

doc: doc lifetime of n-api last error info
Document the lifetime of the structure returned
by napi_get_last_error_info

PR-URL: nodejs#13939
Fixes: nodejs/abi-stable-node#251
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Mar 31, 2018

doc: doc lifetime of n-api last error info
Document the lifetime of the structure returned
by napi_get_last_error_info

PR-URL: nodejs#13939
Fixes: nodejs/abi-stable-node#251
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Apr 6, 2018

doc: doc lifetime of n-api last error info
Document the lifetime of the structure returned
by napi_get_last_error_info

PR-URL: nodejs#13939
Fixes: nodejs/abi-stable-node#251
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Apr 10, 2018

doc: doc lifetime of n-api last error info
Document the lifetime of the structure returned
by napi_get_last_error_info

PR-URL: nodejs#13939
Fixes: nodejs/abi-stable-node#251
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>

MylesBorins added a commit that referenced this pull request Apr 16, 2018

doc: doc lifetime of n-api last error info
Document the lifetime of the structure returned
by napi_get_last_error_info

Backport-PR-URL: #19447
PR-URL: #13939
Fixes: nodejs/abi-stable-node#251
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>

@MylesBorins MylesBorins referenced this pull request Apr 16, 2018

Merged

v6.14.2 proposal #19996

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment