Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors, url: port url errors to internal/errors #13963

Closed
wants to merge 1 commit into from

Conversation

@starkwang
Copy link
Contributor

@starkwang starkwang commented Jun 28, 2017

There is already a PR (#11360) for this migration, but it seems to be out-of-date and deprecated. So I make a new one.

Ref: #11273

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

url, test

@TimothyGu
Copy link
Member

@TimothyGu TimothyGu commented Jun 29, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/8857/

Don't worry if node-test-commit-linux doesn't pass. The CI bot has had some trouble recently.

@refack
refack approved these changes Jun 29, 2017
test/parallel/test-url-format-invalid-input.js Outdated
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError,
message: 'The "urlObj" argument must be of type object. ' +
`Received type ${type}`

This comment has been minimized.

@jasnell

jasnell Jun 29, 2017
Member

nit: line up the strings here.

This comment has been minimized.

@starkwang

starkwang Jun 29, 2017
Author Contributor

fixed

test/parallel/test-url-parse-invalid-input.js Outdated
});

assert.throws(() => { url.parse('http://%E0%A4%A@fail'); },
/^URIError: URI malformed$/);
assert.throws(() => { url.parse('http://%E0%A4%A@fail'); }, /^URIError: URI malformed$/);

This comment has been minimized.

@jasnell

jasnell Jun 29, 2017
Member

long line here?

This comment has been minimized.

@starkwang

starkwang Jun 29, 2017
Author Contributor

OK, I fix it.

@starkwang starkwang force-pushed the starkwang:url-internal-error branch Jun 29, 2017
@starkwang starkwang force-pushed the starkwang:url-internal-error branch to b630e47 Jun 29, 2017
@starkwang starkwang mentioned this pull request Jun 29, 2017
79 of 80 tasks complete
Copy link
Member

@mhdawson mhdawson left a comment

LGTM

refack added a commit to refack/node that referenced this pull request Jul 2, 2017
PR-URL: nodejs#13963
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@refack
Copy link
Member

@refack refack commented Jul 2, 2017

Landed in 473f0ef

@refack refack closed this Jul 2, 2017
@refack
Copy link
Member

@refack refack commented Jul 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Error Codes
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.