New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors, url: port url errors to internal/errors #13963

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
6 participants
@starkwang
Contributor

starkwang commented Jun 28, 2017

There is already a PR (#11360) for this migration, but it seems to be out-of-date and deprecated. So I make a new one.

Ref: #11273

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

url, test

@TimothyGu

This comment has been minimized.

Show comment
Hide comment
@TimothyGu

TimothyGu Jun 29, 2017

Member

CI: https://ci.nodejs.org/job/node-test-pull-request/8857/

Don't worry if node-test-commit-linux doesn't pass. The CI bot has had some trouble recently.

Member

TimothyGu commented Jun 29, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/8857/

Don't worry if node-test-commit-linux doesn't pass. The CI bot has had some trouble recently.

@refack

refack approved these changes Jun 29, 2017

Show outdated Hide outdated test/parallel/test-url-format-invalid-input.js Outdated
Show outdated Hide outdated test/parallel/test-url-parse-invalid-input.js Outdated

@starkwang starkwang referenced this pull request Jun 29, 2017

Closed

Tracking Issue: Migrate errors to internal/errors.js #11273

78 of 80 tasks complete
@mhdawson

LGTM

@mhdawson

This comment has been minimized.

Show comment
Hide comment
Member

mhdawson commented Jun 30, 2017

refack added a commit to refack/node that referenced this pull request Jul 2, 2017

errors,url: port url errors to internal/errors
PR-URL: nodejs#13963
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack Jul 2, 2017

Member

Landed in 473f0ef

Member

refack commented Jul 2, 2017

Landed in 473f0ef

@refack refack closed this Jul 2, 2017

@refack

This comment has been minimized.

Show comment
Hide comment
@refack
Member

refack commented Jul 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment