New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process: use internal/errors in internalNextTick #13982

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@tniessen
Member

tniessen commented Jun 29, 2017

Refs: #12892
Refs: #11273

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

process

@tniessen tniessen added the errors label Jun 29, 2017

@jasnell jasnell referenced this pull request Jun 30, 2017

Closed

Tracking Issue: Migrate errors to internal/errors.js #11273

78 of 80 tasks complete

@tniessen tniessen self-assigned this Jun 30, 2017

@lpinca

lpinca approved these changes Jun 30, 2017

@tniessen

This comment has been minimized.

Show comment
Hide comment
@tniessen

tniessen Jul 2, 2017

Member

Landed in 3129b2c

Member

tniessen commented Jul 2, 2017

Landed in 3129b2c

@tniessen tniessen closed this Jul 2, 2017

tniessen added a commit that referenced this pull request Jul 2, 2017

process: use internal/errors in internalNextTick
PR-URL: #13982
Refs: #12892
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

addaleax added a commit to addaleax/node that referenced this pull request Jul 3, 2017

process: use internal/errors in internalNextTick
PR-URL: nodejs#13982
Refs: nodejs#12892
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@addaleax addaleax referenced this pull request Jul 3, 2017

Merged

v8.2.0 proposal #13744

@mhdawson

This comment has been minimized.

Show comment
Hide comment
@mhdawson

mhdawson Jul 6, 2017

Member

@jasnell I think this should have been marked as SemVer major, will add please remove if thats incorrect.

Member

mhdawson commented Jul 6, 2017

@jasnell I think this should have been marked as SemVer major, will add please remove if thats incorrect.

bidipyne added a commit to bidipyne/node that referenced this pull request Jul 8, 2017

process: use internal/errors in internalNextTick
PR-URL: nodejs#13982
Refs: nodejs#12892
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

addaleax added a commit that referenced this pull request Jul 11, 2017

process: use internal/errors in internalNextTick
PR-URL: #13982
Refs: #12892
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

bidipyne added a commit to bidipyne/node that referenced this pull request Jul 16, 2017

process: use internal/errors in internalNextTick
PR-URL: nodejs#13982
Refs: nodejs#12892
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

bidipyne added a commit to bidipyne/node that referenced this pull request Jul 16, 2017

process: use internal/errors in internalNextTick
PR-URL: nodejs#13982
Refs: nodejs#12892
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

addaleax added a commit that referenced this pull request Jul 18, 2017

process: use internal/errors in internalNextTick
PR-URL: #13982
Refs: #12892
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment