Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process: use internal/errors in internalNextTick #13982

Closed
wants to merge 1 commit into from

Conversation

@tniessen
Copy link
Member

@tniessen tniessen commented Jun 29, 2017

Refs: #12892
Refs: #11273

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

process

@tniessen tniessen added the errors label Jun 29, 2017
@jasnell jasnell mentioned this pull request Jun 30, 2017
79 of 80 tasks complete
@tniessen tniessen self-assigned this Jun 30, 2017
@lpinca
lpinca approved these changes Jun 30, 2017
@tniessen
Copy link
Member Author

@tniessen tniessen commented Jul 2, 2017

Landed in 3129b2c

@tniessen tniessen closed this Jul 2, 2017
tniessen added a commit that referenced this pull request Jul 2, 2017
PR-URL: #13982
Refs: #12892
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax added a commit to addaleax/node that referenced this pull request Jul 3, 2017
PR-URL: nodejs#13982
Refs: nodejs#12892
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@addaleax addaleax mentioned this pull request Jul 3, 2017
@mhdawson
Copy link
Member

@mhdawson mhdawson commented Jul 6, 2017

@jasnell I think this should have been marked as SemVer major, will add please remove if thats incorrect.

addaleax added a commit that referenced this pull request Jul 11, 2017
PR-URL: #13982
Refs: #12892
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax added a commit that referenced this pull request Jul 18, 2017
PR-URL: #13982
Refs: #12892
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.