New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

child_process: use internal/errors #14009

Closed
wants to merge 2 commits into
base: master
from

Conversation

@tniessen
Member

tniessen commented Jun 30, 2017

Refs: #11273

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

child_process

@tniessen

This comment has been minimized.

Show comment
Hide comment

@tniessen tniessen added the errors label Jun 30, 2017

@refack

refack approved these changes Jun 30, 2017

@tniessen tniessen self-assigned this Jun 30, 2017

@jasnell jasnell referenced this pull request Jun 30, 2017

Closed

Tracking Issue: Migrate errors to internal/errors.js #11273

78 of 80 tasks complete

@Trott Trott added the semver-major label Jun 30, 2017

@tniessen

This comment has been minimized.

Show comment
Hide comment
@tniessen

tniessen Jul 2, 2017

Member

@nodejs/ctc due to semverity

Member

tniessen commented Jul 2, 2017

@nodejs/ctc due to semverity

@lpinca

lpinca approved these changes Jul 2, 2017

@mcollina

LGTM as semver-major

@targos

targos approved these changes Jul 3, 2017

tniessen added a commit that referenced this pull request Jul 3, 2017

child_process: use internal/errors
PR-URL: #14009
Refs: #11273
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@tniessen

This comment has been minimized.

Show comment
Hide comment
@tniessen
Member

tniessen commented Jul 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment