New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: allow enabling the --trace-maps flag in V8 #14018

Merged
merged 1 commit into from Jul 7, 2017

Conversation

Projects
None yet
8 participants
@evanlucas
Member

evanlucas commented Jul 1, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

This can be useful for tracing map creation.

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack Jul 1, 2017

Member

Context please?

Member

refack commented Jul 1, 2017

Context please?

Show outdated Hide outdated node.gyp Outdated
Show outdated Hide outdated configure Outdated
@bnoordhuis

This comment has been minimized.

Show comment
Hide comment
@bnoordhuis

bnoordhuis Jul 1, 2017

Member

@refack It's a tool for tracing hidden class transitions. ('hidden class' == 'map' in V8 parlance.)

Member

bnoordhuis commented Jul 1, 2017

@refack It's a tool for tracing hidden class transitions. ('hidden class' == 'map' in V8 parlance.)

@evanlucas

This comment has been minimized.

Show comment
Hide comment
@evanlucas

evanlucas Jul 5, 2017

Member

Updated, PTAL

Member

evanlucas commented Jul 5, 2017

Updated, PTAL

@cjihrig

cjihrig approved these changes Jul 5, 2017

Show outdated Hide outdated configure Outdated
@refack

refack approved these changes Jul 6, 2017

@mhdawson

This comment has been minimized.

Show comment
Hide comment
Member

mhdawson commented Jul 6, 2017

build: allow enabling the --trace-maps flag in V8
This can be useful for tracing map creation.

PR-URL: #14018
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>

@evanlucas evanlucas closed this Jul 7, 2017

@evanlucas evanlucas deleted the evanlucas:tracemaps branch Jul 7, 2017

@evanlucas

This comment has been minimized.

Show comment
Hide comment
@evanlucas

evanlucas Jul 7, 2017

Member

Landed in 49d13a1. Thanks!

Member

evanlucas commented Jul 7, 2017

Landed in 49d13a1. Thanks!

@evanlucas evanlucas merged commit 49d13a1 into nodejs:master Jul 7, 2017

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Jul 11, 2017

Member

@evanlucas This seems to conflict with the snapshot change, can you backport to v8.x?

Member

addaleax commented Jul 11, 2017

@evanlucas This seems to conflict with the snapshot change, can you backport to v8.x?

evanlucas added a commit to evanlucas/node that referenced this pull request Jul 18, 2017

build: allow enabling the --trace-maps flag in V8
This can be useful for tracing map creation.

PR-URL: nodejs#14018
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>

addaleax added a commit that referenced this pull request Jul 18, 2017

build: allow enabling the --trace-maps flag in V8
This can be useful for tracing map creation.

Backport-PR-URL: #14344
Backport-Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Backport-Reviewed-By: Refael Ackermann <refack@gmail.com>
PR-URL: #14018
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>

@addaleax addaleax referenced this pull request Jul 18, 2017

Merged

v8.2.0 proposal #13744

addaleax added a commit that referenced this pull request Jul 18, 2017

build: allow enabling the --trace-maps flag in V8
This can be useful for tracing map creation.

Backport-PR-URL: #14344
Backport-Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Backport-Reviewed-By: Refael Ackermann <refack@gmail.com>
PR-URL: #14018
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>

Fishrock123 added a commit that referenced this pull request Jul 19, 2017

build: allow enabling the --trace-maps flag in V8
This can be useful for tracing map creation.

Backport-PR-URL: #14344
Backport-Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Backport-Reviewed-By: Refael Ackermann <refack@gmail.com>
PR-URL: #14018
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Aug 16, 2017

Member

Should this have been semver-minor?

Should we backport to lts?

Member

MylesBorins commented Aug 16, 2017

Should this have been semver-minor?

Should we backport to lts?

@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins
Member

MylesBorins commented Sep 19, 2017

ping @evanlucas

@evanlucas

This comment has been minimized.

Show comment
Hide comment
@evanlucas

evanlucas Oct 2, 2017

Member

@MylesBorins sorry I somehow missed your previous comment. I think it could be argued either way that this is semver-minor. It isn't exposed in release builds and can only be done when using ./configure. I'll try to get around to opening a backport PR, although this isn't something extremely pressing to backport.

Member

evanlucas commented Oct 2, 2017

@MylesBorins sorry I somehow missed your previous comment. I think it could be argued either way that this is semver-minor. It isn't exposed in release builds and can only be done when using ./configure. I'll try to get around to opening a backport PR, although this isn't something extremely pressing to backport.

@bnoordhuis

This comment has been minimized.

Show comment
Hide comment
@bnoordhuis

bnoordhuis Oct 24, 2017

Member

https://chromium-review.googlesource.com/c/v8/v8/+/734648 -- --trace-maps might soon be available by default, no build flags needed.

Member

bnoordhuis commented Oct 24, 2017

https://chromium-review.googlesource.com/c/v8/v8/+/734648 -- --trace-maps might soon be available by default, no build flags needed.

@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Dec 19, 2017

Member

I've landed on v6.x. Please lmk if there are any concerns

Member

MylesBorins commented Dec 19, 2017

I've landed on v6.x. Please lmk if there are any concerns

MylesBorins added a commit that referenced this pull request Dec 19, 2017

build: allow enabling the --trace-maps flag in V8
This can be useful for tracing map creation.

PR-URL: #14018
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 20, 2017

Merged

v6.12.3 proposal #17776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment