New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: use `error` instead of 2 #14061

Merged
merged 1 commit into from Jul 5, 2017

Conversation

@refack
Member

refack commented Jul 3, 2017

We are already using the "cleaner" YAML variant, so why not use the error symbol instead of the quite confusing 2 value?

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

tools

@benjamingr

+1 for change, content LGTM

@refack

This comment has been minimized.

Show comment
Hide comment
Member

refack commented Jul 3, 2017

@refack refack self-assigned this Jul 3, 2017

@refack

This comment has been minimized.

Show comment
Hide comment
@refack
Member

refack commented Jul 3, 2017

@targos

targos approved these changes Jul 3, 2017

@cjihrig

cjihrig approved these changes Jul 3, 2017

@fhinkel

fhinkel approved these changes Jul 3, 2017

@lpinca

lpinca approved these changes Jul 4, 2017

tools: eslint - use `error` and `off`
PR-URL: #14061
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@refack refack merged commit 46d7cb8 into nodejs:master Jul 5, 2017

@refack refack deleted the refack:eslint-rules-2-to-error branch Jul 5, 2017

addaleax added a commit that referenced this pull request Jul 11, 2017

tools: eslint - use `error` and `off`
PR-URL: #14061
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@addaleax addaleax referenced this pull request Jul 11, 2017

Merged

v8.2.0 proposal #13744

addaleax added a commit that referenced this pull request Jul 18, 2017

tools: eslint - use `error` and `off`
PR-URL: #14061
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Fishrock123 added a commit that referenced this pull request Jul 19, 2017

tools: eslint - use `error` and `off`
PR-URL: #14061
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Aug 15, 2017

Member

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if no let me know or add the dont-land-on label.

Member

MylesBorins commented Aug 15, 2017

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if no let me know or add the dont-land-on label.

refack added a commit to refack/node that referenced this pull request Aug 15, 2017

tools: eslint - use `error` and `off`
PR-URL: nodejs#14061
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

# Conflicts:
#	.eslintrc.yaml
#	benchmark/.eslintrc.yaml
#	doc/.eslintrc.yaml
#	test/.eslintrc.yaml
#	tools/.eslintrc.yaml

refack added a commit to refack/node that referenced this pull request Aug 15, 2017

tools: eslint - use `error` and `off`
PR-URL: nodejs#14061
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

# Conflicts:
#	.eslintrc.yaml
#	benchmark/.eslintrc.yaml
#	doc/.eslintrc.yaml
#	test/.eslintrc.yaml
#	tools/.eslintrc.yaml

@refack refack referenced this pull request Aug 15, 2017

Closed

[v6.x backport] tools: eslint - use `error` and `off` #14841

2 of 2 tasks complete
@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack Aug 15, 2017

Member

Backport PR: #14841

Member

refack commented Aug 15, 2017

Backport PR: #14841

refack added a commit to refack/node that referenced this pull request Sep 19, 2017

tools: eslint - use `error` and `off`
PR-URL: nodejs#14061
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

# Conflicts:
#	.eslintrc.yaml
#	benchmark/.eslintrc.yaml
#	doc/.eslintrc.yaml
#	test/.eslintrc.yaml
#	tools/.eslintrc.yaml

refack added a commit to refack/node that referenced this pull request Sep 19, 2017

tools: eslint - use `error` and `off`
PR-URL: nodejs#14061
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

# Conflicts:
#	.eslintrc.yaml
#	benchmark/.eslintrc.yaml
#	doc/.eslintrc.yaml
#	test/.eslintrc.yaml
#	tools/.eslintrc.yaml

MylesBorins added a commit that referenced this pull request Sep 19, 2017

tools: eslint - use `error` and `off`
Backport-PR-URL: #14841
PR-URL: #14061
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@MylesBorins MylesBorins referenced this pull request Sep 20, 2017

Merged

v6.11.4 proposal #15506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment