Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url: update sort() behavior with no params #14185

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
6 participants
@TimothyGu
Copy link
Member

commented Jul 12, 2017

This reverts commit b465cd0.

Refs: web-platform-tests/wpt#6445
Fixes: #14020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

url

@mscdex

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2017

I think the commit message should be the standard/default revert message (as far as the non-metadata text goes).

@TimothyGu TimothyGu changed the title url: revert "fix URL query update if searchParams changes" Revert "url: fix URL query update if searchParams changes" Jul 12, 2017

@TimothyGu TimothyGu force-pushed the TimothyGu:url-searchparams-update branch from 66feb3f to e6ada88 Jul 12, 2017

@targos

This comment has been minimized.

Copy link
Member

commented Jul 12, 2017

Is there any active discussion about changing the spec, knowing that Chrome, Firefox and Node are currently doing the same thing? I found whatwg/url#332 which has no answer.

@TimothyGu

This comment has been minimized.

Copy link
Member Author

commented Jul 12, 2017

@targos I'll put this on hold until whatwg/url#332 is resolved.

@targos

This comment has been minimized.

Copy link
Member

commented Jul 18, 2017

Now that whatwg/url#336 has been merged, this is not needed anymore.
I think that now we are almost spec-compliant. Calling url.searchParams.sort() with empty searchParams should remove the trailing ? but it does not in Node (it's taking a shortcut here).

@TimothyGu TimothyGu force-pushed the TimothyGu:url-searchparams-update branch from e6ada88 to bb48b2b Jul 24, 2017

@TimothyGu TimothyGu changed the title Revert "url: fix URL query update if searchParams changes" url: update sort() behavior with no params Jul 24, 2017

@TimothyGu

This comment has been minimized.

Copy link
Member Author

commented Jul 24, 2017

I've rebased this on top of master and it now implements the revised spec. Tests are added accordingly.

@TimothyGu

This comment has been minimized.

Copy link
Member Author

commented Jul 24, 2017

@targos

targos approved these changes Jul 24, 2017

@TimothyGu

This comment has been minimized.

Copy link
Member Author

commented Jul 30, 2017

@jasnell @joyeecheung mind taking a look?

@refack

refack approved these changes Jul 30, 2017

@TimothyGu

This comment has been minimized.

Copy link
Member Author

commented Aug 1, 2017

Landed in 57630ad.

@TimothyGu TimothyGu closed this Aug 1, 2017

TimothyGu added a commit that referenced this pull request Aug 1, 2017

url: update sort() behavior with no params
PR-URL: #14185
Refs: whatwg/url#336
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax added a commit that referenced this pull request Aug 1, 2017

url: update sort() behavior with no params
PR-URL: #14185
Refs: whatwg/url#336
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@addaleax addaleax referenced this pull request Aug 2, 2017

Merged

v8.3.0 proposal #14594

@TimothyGu TimothyGu deleted the TimothyGu:url-searchparams-update branch Jul 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.