New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: document napi_finalize() signature #14230

Merged
merged 1 commit into from Jul 31, 2017

Conversation

Projects
None yet
8 participants
@cjihrig
Contributor

cjihrig commented Jul 14, 2017

Refs: #14138

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@refack

refack approved these changes Jul 14, 2017

@mhdawson

LGTM

@cjihrig

This comment has been minimized.

Show comment
Hide comment
Contributor

cjihrig commented Jul 31, 2017

doc: document napi_finalize() signature
Refs: #14138
PR-URL: #14230
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

@cjihrig cjihrig merged commit 6968ead into nodejs:master Jul 31, 2017

@cjihrig cjihrig deleted the cjihrig:finalize-docs branch Jul 31, 2017

addaleax added a commit that referenced this pull request Aug 1, 2017

doc: document napi_finalize() signature
Refs: #14138
PR-URL: #14230
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

@addaleax addaleax referenced this pull request Aug 2, 2017

Merged

v8.3.0 proposal #14594

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Mar 12, 2018

doc: document napi_finalize() signature
Refs: nodejs#14138
PR-URL: nodejs#14230
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Mar 15, 2018

doc: document napi_finalize() signature
Refs: nodejs#14138
PR-URL: nodejs#14230
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Apr 3, 2018

doc: document napi_finalize() signature
Refs: nodejs#14138
PR-URL: nodejs#14230
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Apr 6, 2018

doc: document napi_finalize() signature
Refs: nodejs#14138
PR-URL: nodejs#14230
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Apr 10, 2018

doc: document napi_finalize() signature
Refs: nodejs#14138
PR-URL: nodejs#14230
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

MylesBorins added a commit that referenced this pull request Apr 16, 2018

doc: document napi_finalize() signature
Refs: #14138
Backport-PR-URL: #19447
PR-URL: #14230
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

@MylesBorins MylesBorins referenced this pull request Apr 16, 2018

Merged

v6.14.2 proposal #19996

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment