New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add note for build path #14354

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
@kylelamse

kylelamse commented Jul 18, 2017

Fixes: #14337

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Show outdated Hide outdated BUILDING.md
@vsemozhetbyt

This comment has been minimized.

Show comment
Hide comment
@vsemozhetbyt

vsemozhetbyt Jul 18, 2017

Member

Overal LGTM, but @addaleax's comment re note expanding should be considered.

Member

vsemozhetbyt commented Jul 18, 2017

Overal LGTM, but @addaleax's comment re note expanding should be considered.

@kylelamse

This comment has been minimized.

Show comment
Hide comment
@kylelamse

kylelamse Jul 18, 2017

@addaleax the reason why I put it in the Windows-specific section is because in #14337 the vcbuild.bat script tried to reference my home path here:

'C:\Users\Kyle\icupkg' is not recognized as an internal or external command,
  operable program or batch file.

I dropped the repo in my root directory, ran the .bat file, and it still attempted to execute icupkg in the same path. My home path was C:\Users\Kyle Lamse\ so it looks like it chopped off my last name.

kylelamse commented Jul 18, 2017

@addaleax the reason why I put it in the Windows-specific section is because in #14337 the vcbuild.bat script tried to reference my home path here:

'C:\Users\Kyle\icupkg' is not recognized as an internal or external command,
  operable program or batch file.

I dropped the repo in my root directory, ran the .bat file, and it still attempted to execute icupkg in the same path. My home path was C:\Users\Kyle Lamse\ so it looks like it chopped off my last name.

@mscdex mscdex added the windows label Jul 18, 2017

@gibfahn

This comment has been minimized.

Show comment
Hide comment
@gibfahn

gibfahn Jul 18, 2017

Member

Why not put it under ## Building Node.js on supported platforms, we want it to be visible for anyone going into that section.

While you're at it, could you wrap to 80 chars?

Member

gibfahn commented Jul 18, 2017

Why not put it under ## Building Node.js on supported platforms, we want it to be visible for anyone going into that section.

While you're at it, could you wrap to 80 chars?

@vsemozhetbyt vsemozhetbyt changed the title from doc: add note for Windows build path to doc: add note for build path Jul 19, 2017

Show outdated Hide outdated BUILDING.md
@refack

refack approved these changes Jul 19, 2017

Show outdated Hide outdated BUILDING.md
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 24, 2017

Member

Ping @refack @addaleax and @vsemozhetbyt . please take another look, I added a commit the addressed the standing feedback

Member

jasnell commented Aug 24, 2017

Ping @refack @addaleax and @vsemozhetbyt . please take another look, I added a commit the addressed the standing feedback

@refack

refack approved these changes Aug 24, 2017

jasnell added a commit that referenced this pull request Aug 24, 2017

doc: add note for Windows build path
PR-URL: #14354
Fixes: #14337
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 24, 2017

Member

Landed in 43029da

Member

jasnell commented Aug 24, 2017

Landed in 43029da

@jasnell jasnell closed this Aug 24, 2017

addaleax added a commit to addaleax/ayo that referenced this pull request Aug 25, 2017

doc: add note for Windows build path
PR-URL: nodejs/node#14354
Fixes: nodejs/node#14337
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

addaleax added a commit to ayojs/ayo that referenced this pull request Aug 28, 2017

doc: add note for Windows build path
PR-URL: nodejs/node#14354
Fixes: nodejs/node#14337
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins added a commit that referenced this pull request Sep 10, 2017

doc: add note for Windows build path
PR-URL: #14354
Fixes: #14337
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@MylesBorins MylesBorins referenced this pull request Sep 10, 2017

Merged

v8.5.0 proposal #15308

MylesBorins added a commit that referenced this pull request Sep 12, 2017

doc: add note for Windows build path
PR-URL: #14354
Fixes: #14337
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins added a commit that referenced this pull request Sep 20, 2017

doc: add note for Windows build path
PR-URL: #14354
Fixes: #14337
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@MylesBorins MylesBorins referenced this pull request Sep 20, 2017

Merged

v6.11.4 proposal #15506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment