New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve zlib tests #14455

Closed
wants to merge 10 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@jasnell
Member

jasnell commented Jul 24, 2017

Multiple general improvements to zlib tests

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@mscdex mscdex added the zlib label Jul 24, 2017

@Trott

The changes to zlib-random-byte-pipes introduce flakiness under load that is not there currently.

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Jul 24, 2017

Member

With changes in this PR:

$ tools/test.py -j 96 --repeat 96 test/parallel/test-zlib-random-byte-pipes.js
=== release test-zlib-random-byte-pipes ===                                    
Path: parallel/test-zlib-random-byte-pipes
Mismatched noop function calls. Expected exactly 4, actual 5.
    at Object.exports.mustCall (/Users/trott/io.js/test/common/index.js:475:10)
    at Object.<anonymous> (/Users/trott/io.js/test/parallel/test-zlib-random-byte-pipes.js:153:23)
    at Module._compile (module.js:573:30)
    at Object.Module._extensions..js (module.js:584:10)
    at Module.load (module.js:507:32)
    at tryModuleLoad (module.js:470:12)
    at Function.Module._load (module.js:462:3)
    at Function.Module.runMain (module.js:609:10)
    at startup (bootstrap_node.js:158:16)
Command: out/Release/node /Users/trott/io.js/test/parallel/test-zlib-random-byte-pipes.js
=== release test-zlib-random-byte-pipes === 
Path: parallel/test-zlib-random-byte-pipes
Mismatched noop function calls. Expected exactly 4, actual 5.
    at Object.exports.mustCall (/Users/trott/io.js/test/common/index.js:475:10)
    at Object.<anonymous> (/Users/trott/io.js/test/parallel/test-zlib-random-byte-pipes.js:153:23)
    at Module._compile (module.js:573:30)
    at Object.Module._extensions..js (module.js:584:10)
    at Module.load (module.js:507:32)
    at tryModuleLoad (module.js:470:12)
    at Function.Module._load (module.js:462:3)
    at Function.Module.runMain (module.js:609:10)
    at startup (bootstrap_node.js:158:16)
Command: out/Release/node /Users/trott/io.js/test/parallel/test-zlib-random-byte-pipes.js
[...snip...]

On current master:

$ tools/test.py -j 96 --repeat 96 test/parallel/test-zlib-random-byte-pipes.js 
[00:11|% 100|+  96|-   0]: Done                                
$
Member

Trott commented Jul 24, 2017

With changes in this PR:

$ tools/test.py -j 96 --repeat 96 test/parallel/test-zlib-random-byte-pipes.js
=== release test-zlib-random-byte-pipes ===                                    
Path: parallel/test-zlib-random-byte-pipes
Mismatched noop function calls. Expected exactly 4, actual 5.
    at Object.exports.mustCall (/Users/trott/io.js/test/common/index.js:475:10)
    at Object.<anonymous> (/Users/trott/io.js/test/parallel/test-zlib-random-byte-pipes.js:153:23)
    at Module._compile (module.js:573:30)
    at Object.Module._extensions..js (module.js:584:10)
    at Module.load (module.js:507:32)
    at tryModuleLoad (module.js:470:12)
    at Function.Module._load (module.js:462:3)
    at Function.Module.runMain (module.js:609:10)
    at startup (bootstrap_node.js:158:16)
Command: out/Release/node /Users/trott/io.js/test/parallel/test-zlib-random-byte-pipes.js
=== release test-zlib-random-byte-pipes === 
Path: parallel/test-zlib-random-byte-pipes
Mismatched noop function calls. Expected exactly 4, actual 5.
    at Object.exports.mustCall (/Users/trott/io.js/test/common/index.js:475:10)
    at Object.<anonymous> (/Users/trott/io.js/test/parallel/test-zlib-random-byte-pipes.js:153:23)
    at Module._compile (module.js:573:30)
    at Object.Module._extensions..js (module.js:584:10)
    at Module.load (module.js:507:32)
    at tryModuleLoad (module.js:470:12)
    at Function.Module._load (module.js:462:3)
    at Function.Module.runMain (module.js:609:10)
    at startup (bootstrap_node.js:158:16)
Command: out/Release/node /Users/trott/io.js/test/parallel/test-zlib-random-byte-pipes.js
[...snip...]

On current master:

$ tools/test.py -j 96 --repeat 96 test/parallel/test-zlib-random-byte-pipes.js 
[00:11|% 100|+  96|-   0]: Done                                
$
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Jul 24, 2017

Member

@Trott ... updated

Member

jasnell commented Jul 24, 2017

@Trott ... updated

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 2, 2017

Member

ping @Trott ... I know this needs a rebase, but when you get a moment to take another look I'd appreciate it :-)

Member

jasnell commented Aug 2, 2017

ping @Trott ... I know this needs a rebase, but when you get a moment to take another look I'd appreciate it :-)

@Trott Trott dismissed their stale review Aug 2, 2017

comments addressed, dismissing review

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott
Member

Trott commented Aug 2, 2017

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 3, 2017

Member

Rebased!

Member

jasnell commented Aug 3, 2017

Rebased!

@jasnell jasnell requested a review from addaleax Aug 3, 2017

@addaleax

LGTM, two small comments but nothing I’d consider blocking

@jasnell

This comment has been minimized.

Show comment
Hide comment
Member

jasnell commented Aug 3, 2017

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 4, 2017

Member

Only failure is unrelated.

Member

jasnell commented Aug 4, 2017

Only failure is unrelated.

jasnell added a commit that referenced this pull request Aug 4, 2017

test: improve multiple zlib tests
PR-URL: #14455
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 4, 2017

Member

Landed in 4e8bc71

Member

jasnell commented Aug 4, 2017

Landed in 4e8bc71

@jasnell jasnell closed this Aug 4, 2017

MylesBorins added a commit that referenced this pull request Sep 9, 2017

test: improve multiple zlib tests
PR-URL: #14455
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@MylesBorins MylesBorins referenced this pull request Sep 10, 2017

Merged

v8.5.0 proposal #15308

MylesBorins added a commit that referenced this pull request Sep 20, 2017

test: improve multiple zlib tests
PR-URL: #14455
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins added a commit that referenced this pull request Sep 20, 2017

test: improve multiple zlib tests
PR-URL: #14455
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@MylesBorins MylesBorins referenced this pull request Sep 20, 2017

Merged

v6.11.4 proposal #15506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment