Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
src: replace assert with CHECK_LE in node_api.cc #14514
Actually, I'm going to have renege on my LGTM earlier. This file is AFAIK shared with an outside project that don't have access to the internal
CHECK macros. I remember @gabrielschulhof said this might not be true any more after #14217 (comment), but I'd like to block this first before confirmation that such change is acceptable.
@TimothyGu Actually the