New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8.3.0 proposal #14594

Merged
merged 157 commits into from Aug 10, 2017

Conversation

Projects
None yet
@addaleax
Member

addaleax commented Aug 2, 2017

For real this time.

2017-08-??, Version 8.3.0 (Current), @addaleax

Notable changes

V8 6.0

The V8 engine has been upgraded to version 6.0, which has a significantly
changed performance profile.
#14574

More detailed information on performance differences can be found at
https://medium.com/the-node-js-collection/get-ready-a-new-v8-is-coming-node-js-performance-is-changing-46a63d6da4de

Other notable changes

  • DNS

    • Independent DNS resolver instances are supported now, with support for
      cancelling the corresponding requests.
      #14518
  • REPL

    • Autocompletion support for require() has been improved.
      #14409
  • Utilities

    • The WHATWG Encoding Standard (TextDecoder and TextEncoder) has
      been implemented.
      #13644
  • Added new collaborators

Commits

  • [e2356e72e7] - assert: improve deepEqual Set and Map worst case (Ruben Bridgewater) #14258
  • [9252b8c057] - assert: refactor to reduce unecessary code paths (Ruben Bridgewater) #13973
  • [89586f6684] - assert: fix incorrect use of ERR_INVALID_ARG_TYPE (Tobias Nießen) #14011
  • [26785a23bb] - assert: refactor the code (Ruben Bridgewater) #13862
  • [0cf1e22448] - benchmark: remove unused parameters (Matthew Alsup) #14526
  • [9b104b4ea8] - benchmark: add assert map and set benchmarks (Ruben Bridgewater) #14258
  • [2c364ab291] - buffer: remove a wrongly added attribute specifier (Jiajie Hu) #14466
  • [87e108059b] - build: fix build without icu (Jimmy Thomson) #14533
  • [0ebb4dff17] - build: codesign tarball binary on macOS (Evan Lucas) #14179
  • [7f5bcbd2e9] - build,test: run v8 tests on windows (Kunal Pathak) #13992
  • [5ab4471d72] - build,tools: do not force codesign prefix (Evan Lucas) #14179
  • [7b96944254] - build,win: fix python detection script (Jason Ginchereau) #14546
  • [51c1afafa6] - crypto: change segmentation faults to CHECKs (Tobias Nießen) #14548
  • [e2b306c831] - (SEMVER-MINOR) deps: backport rehash strings after deserialization (Yang Guo) #14004
  • [2dbf95d5ee] - (SEMVER-MINOR) deps: backport c0f1ff2 from upstream V8 (Michaël Zasso) #14004
  • [efd297a5c9] - (SEMVER-MINOR) deps: fix addons compilation with VS2013 (Bartosz Sosnowski) #14004
  • [160e2f03d2] - (SEMVER-MINOR) deps: limit regress/regress-crbug-514081 v8 test (Michael Dawson) #14004
  • [44ad55d493] - (SEMVER-MINOR) deps: update V8 to 6.0.286.52 (Myles Borins) #14574
  • [d9273ed5ed] - deps: cherry-pick 18ea996 from c-ares upstream (Anna Henningsen) #13883
  • [32b30d519e] - (SEMVER-MINOR) dns: name generated functions (Anna Henningsen) #14518
  • [0982810208] - (SEMVER-MINOR) dns: add channel.cancel() (Anna Henningsen) #14518
  • [69e41dc5da] - (SEMVER-MINOR) dns: enable usage of independent cares resolvers (Anna Henningsen) #14518
  • [b6bd3cf00f] - doc: cross-link util.TextDecoder and intl.md (Vse Mozhet Byt) #14486
  • [fffd8f5335] - doc: document napi_finalize() signature (cjihrig) #14230
  • [92b0555965] - doc: various small revisions in url (Timothy Gu) #14478
  • [9dd9760951] - doc: update url.origin IDNA behavior (Timothy Gu) #14478
  • [4e2493a20d] - doc: fix minor typos in net.md (Daiki Arai) #14502
  • [e9088f92d8] - doc: fix verify in crypto.md (Ruslan Iusupov) #14469
  • [8a9de1b3c5] - doc: fix typo in using-internal-errors.md (Anton Paras) #14429
  • [ab9bc81b0e] - doc: add docs for module.paths (atever) #14435
  • [bdcd496c98] - doc: update experimental status to reflect use (James M Snell) #12723
  • [6c6da38518] - doc: fix some links (Vse Mozhet Byt) #14400
  • [83c8e5c517] - doc: describe labelling process for backports (Anna Henningsen) #12431
  • [592787ef4d] - doc: error message are still major (Refael Ackermann) #14375
  • [f1b09c0a44] - doc: fix typo in stream.md (Marc Hernández Cabot) #14364
  • [4be373bc4b] - doc: fixes default shell in child_process.md (Henry) #14203
  • [b12924d894] - doc: add XadillaX to collaborators (XadillaX) #14388
  • [dc0a26f254] - doc: replace dead link in v8 module (Devin Boyer) #14372
  • [d2121ab768] - doc: fix minor typo in cluster.md (Lance Ball) #14353
  • [eb023ef7df] - doc, lib, test: do not re-require needlessly (Vse Mozhet Byt) #14244
  • [cfed48e81c] - doc, url: add changelog metadata for url.format (Timothy Gu) #14543
  • [78f0c2aa75] - doc,assert: document stackStartFunction in fail (Ruben Bridgewater) #13862
  • [53ad91c3b1] - doc,stream: _transform happens one at a time (Matteo Collina) #14321
  • [f6a03439d8] - docs: add note about fs.rmdir() (Oleksandr Kushchak) #14323
  • [142ce5ce2c] - errors: order internal errors list alphabetically (Anna Henningsen) #14453
  • [50447e837b] - http: reset stream to unconsumed in unconsume() (Anna Henningsen) #14410
  • [751e87338f] - http: check for handle before running asyncReset() (Trevor Norris) #14419
  • [71cb1cdf69] - inspector: implement V8Inspector timer (Eugene Ostroukhov) #14346
  • [4836f3b9b9] - inspector: send messages after the Node is done (Eugene Ostroukhov) #14463
  • [9e5a08884a] - lib: adjust indentation for impending lint change (Rich Trott) #14403
  • [a7b3e06e9b] - lib: modify destructuring for indentation (Rich Trott) #14417
  • [28f0693796] - lib: include cached modules in module.children (Ben Noordhuis) #14132
  • [19a0e06317] - linkedlist: correct grammar in comments (alexbostock) #14546
  • [60e0f2bb0d] - (SEMVER-MINOR) n-api: add support for DataView (Shivanth MP) #14382
  • [b849b3d223] - n-api: re-use napi_env between modules (Gabriel Schulhof) #14217
  • [6078dea35d] - n-api: directly create Local from Persistent (Kyle Farnung) #14211
  • [f2efdc880f] - (SEMVER-MINOR) n-api: add code parameter to error helpers (Michael Dawson) #13988
  • [fa134dd60c] - n-api: add fast paths for integer getters (Anna Henningsen) #14393
  • [58446912a6] - net: fix bytesWritten during writev (Brendan Ashworth) #14236
  • [b41ae9847e] - path: fix win32 volume-relative paths (Timothy Gu) #14440
  • [509039fcaf] - path: remove unnecessary string copies (Tobias Nießen) #14438
  • [37e55bf559] - readline: remove max limit of crlfDelay (Azard) #13497
  • [e54f75b831] - readline: remove the caching variable (Lyall Sun) #14275
  • [1a5927fc27] - repl: do not consider ... as a REPL command (Shivanth MP) #14467
  • [5a8862bfa3] - (SEMVER-MINOR) repl: improve require() autocompletion (Alexey Orlenko) #14409
  • [34821f6400] - repl: don't terminate on null thrown (Benjamin Gruenbaum) #14306
  • [32ba8aea0b] - repl: fix old history error handling (Ruben Bridgewater) #13733
  • [8a3bc874fa] - src: fix process.abort() interaction with V8 (Anna Henningsen) #13985
  • [997204a213] - (SEMVER-MINOR) src: fix new V8 compiler warnings (Michaël Zasso) #14004
  • [fa3aa2e1f7] - src: return MaybeLocal in AsyncWrap::MakeCallback (Tobias Nießen) #14549
  • [d90a5e0069] - src: replace deprecated ForceSet() method (Franziska Hinkelmann) #14450
  • [eb7faf6734] - src: replace ASSERT with CHECK (Ben Noordhuis) #14474
  • [106a23bd27] - (SEMVER-MINOR) src,dns: refactor cares_wrap to avoid global state (Anna Henningsen) #14518
  • [b1fef05446] - test: improvements to various http tests (James M Snell) #14315
  • [ce9e3cfe10] - test: refactor test/sequential/test-fs-watch.js (Rich Trott) #14534
  • [9f50db2450] - test: refactor test-vm-new-script-new-context (Rich Trott) #14536
  • [f40b9062fc] - test: add check on an addon that does not register (Ezequiel Garcia) #13954
  • [ddd97fe15c] - test: fix error when foo in path to git clone (Matt Woicik) #14506
  • [8fea17484d] - test: add DISABLED_ prefix to commented out test (Daniel Bevenius) #14317
  • [7b6a77403c] - test: remove disabled tests directory (Rich Trott) #14505
  • [15b9aa1359] - test: improve error logging for inspector test (Rich Trott) #14508
  • [451e643cf2] - test: remove --no-crankshaft (Myles Borins) #14531
  • [7c51240b1a] - test: adjust indentation for stricter linting (Rich Trott) #14431
  • [c704c02290] - test: increase coverage for path.parse (Tobias Nießen) #14438
  • [23cd934d71] - test: refactor test-httpparser.response.js (erdun) #14290
  • [91b6ba1973] - test: refactor test-benchmark-timers (Rich Trott) #14464
  • [c2853893cf] - test: refactor test-http-parser.js (Rich Trott) #14431
  • [4ff562f41e] - test: make flaky crypto test more deterministic (Ben Noordhuis) #14451
  • [100e862dfa] - test: rename crypto test (Ben Noordhuis) #14451
  • [f8c2302a66] - test: use common.mustCall() instead of exit handle (笑斌) #14262
  • [0ff19b0c4c] - test: changed error message validator (Pratik Jain) #14443
  • [14f6a5a367] - test: fix flaky test-force-repl (Rich Trott) #14439
  • [5057c7a953] - test: replace concatenation with template literal (rockcoder23) #14270
  • [6420a73f3e] - test: replace concatenation with template literal (Ching Hsu) #14284
  • [cd0fffd86a] - test: convert table in test doc to markdown table (vixony) #14291
  • [1c6135f431] - test: fix flaky http(s)-set-server-timeout tests (Rich Trott) #14380
  • [de3d73c88c] - test: replace CRLF by LF in a fixture (Vse Mozhet Byt) #14437
  • [aeb8d66eec] - test: fix test-async-wrap-getasyncid flakyness (Julien Gilli) #14329
  • [3c50c592a5] - test: replace concatenation with template literals (笑斌) #14293
  • [1813467d27] - test: upgrade tests to work with master’s common (Anna Henningsen) #14459
  • [d89bb1c6f3] - test: bump test/common to master (Anna Henningsen) #14459
  • [d7a1637897] - test: change isAix to isAIX (章礼平) #14263
  • [552d2be625] - test: improve test-util-inspect (Peter Marshall) #14003
  • [0418a70d7c] - test: add non-internet resolveAny tests (Anna Henningsen) #13883
  • [265f159881] - test: replace concatenation with template literals (Song, Bintao Garfield) #14295
  • [3414e42127] - test: replace concatenation with template literals (Zongmin Lei) #14298
  • [953736cdde] - test: move timing-dependent tests to sequential (Alexey Orlenko) #14377
  • [9b22acc29e] - test: fix flaky test-net-write-after-close (Rich Trott) #14361
  • [11ae8c33bd] - test: delete obsolete test-sendfd.js (decareano) #14334
  • [99104e1b58] - test: improve fs.exists coverage (jkzing) #14301
  • [e237720537] - test: replace string concatenation with template (ziyun) #14286
  • [3c92b787d7] - test: use path.join in async-hooks/test-tlswrap.js (Vincent Xue) #14319
  • [0197ba00a5] - test: add comments for whatwg-url tests (Gautam Arora) #14355
  • [956a473107] - test: move test-fs-largefile to pummel (Rich Trott) #14338
  • [c866c9078b] - test: use path.join for long path concatenation (zzz) #14280
  • [94c7331277] - test: replace string concatenation with path.join (jkzing) #14272
  • [def98c6959] - test: replace string concatenation with template (Nathan Jiang) #14342
  • [3bc7d2a5ea] - test: replace string concat in test-fs-watchfile.js (Helianthus21) #14287
  • [72febfd3b6] - test: replace concatenation with template literals (SkyAo) #14296
  • [b5d0a03a9e] - test: fix error handling test-http-full-response (Rich Trott) #14252
  • [e90af29604] - tls: fix empty issuer/subject/infoAccess parsing (Ben Noordhuis) #14473
  • [fa8c5f4372] - tools: remove legacy indentation linting (Rich Trott) #14515
  • [d11840c180] - tools: enable stricter linting in lib directory (Rich Trott) #14403
  • [5e952182e7] - tools: update to ESLint 4.3.0 (Rich Trott) #14417
  • [ebb90900af] - tools: skip workaround for newer llvm (nanaya) #14077
  • [c0ea5d8ce5] - tools: always include llvm_version in config (nanaya) #14077
  • [32259421ca] - url: update sort() behavior with no params (Timothy Gu) #14185
  • [9a3fc10dd4] - (SEMVER-MINOR) util: implement WHATWG Encoding Standard API (James M Snell) #13644
  • [f593960d35] - util: refactor util module (James M Snell) #13803
  • [357873ddb0] - (SEMVER-MINOR) v8: fix stack overflow in recursive method (Ben Noordhuis) #14004
  • [e529914e70] - zlib: fix interaction of flushing and needDrain (Anna Henningsen) #14527

BridgeAR and others added some commits Jun 17, 2017

repl: fix old history error handling
Backport-PR-URL: #14392
Backport-Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #13733
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
test: fix error handling test-http-full-response
The way it is currently written, test-http-full-response will fail if
there is a problem with spawning that doesn't include `ab` or `api` in
`stderr`, but it will fail with a misleading mismatched-calls
`common.mustCall()` error.

Alter the error handling so that it rethrows the actual error, providing
better information.

PR-URL: #14252
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
build,tools: do not force codesign prefix
Allow passing the prefix in via the PKGDIR env var. This will allow us
to use this same script to codesign the binary tarball.

PR-URL: #14179
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
build: codesign tarball binary on macOS
Previously, we were signing the binary that was released in the .pkg,
but not the binary released in the tarball.

PR-URL: #14179
Fixes: #11936
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
test: use path.join for long path concatenation
PR-URL: #14280
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
test: replace string concatenation with path.join
PR-URL: #14272
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
test: replace string concat in test-fs-watchfile.js
PR-URL: #14287
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
test: replace concatenation with template literals
Use template literals instead of string concatenation in
test/parallel/test-http-extra-response.js

PR-URL: #14296
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
repl: don't terminate on null thrown
Previous behavior was to assume an error is a proper error in the
repl module. A check was added to not terminate the process on thrown
repl errors that are `null` or `undefined`.

PR-URL: #14306
Fixes: #12373
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com
doc,stream: _transform happens one at a time
Add a note to the stream docs specifying that at most a single
call to _transform can happen, and the provided callback()
should be used to process another chunk.

Fixes: #3208
PR-URL: #14321
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
docs: add note about fs.rmdir()
fs.rmdir() on the file (not directory) results in different errors on
Windows to everything else

Fixes: #8797
PR-URL: #14323
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
test: replace string concatenation with template
PR-URL: #14342
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
doc: fix minor typo in cluster.md
Adds a missing `'` in code example.

PR-URL: #14353
Fixes: #14352
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
doc: replace dead link in v8 module
PR-URL: #14372
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
doc: fixes default shell in child_process.md
Clarifies the default shell in Windows is process.env.ComSpec
and that cmd.exe is only used as a fallback. Functions whose
descriptions are affected include:
child_process.spawn, child_process.exec,
child_process.spawnsSync, and child_process.execSync.

PR-URL: #14203
Fixes: #14156
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
readline: remove the caching variable
Line 486 and 525 contain for loops where a length property is cached in
a variable (for example, itemLen). This used to be a performance
optimization, but current V8 handles the optimization internally.

These caching variables are removed, and the length property is used
directly instead.

PR-URL: #14275
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
test: replace string concatenation with template
PR-URL: #14286
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
test: improve fs.exists coverage
By adding a test case using a path with illegal protocol

PR-URL: #14301
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
test: use path.join in async-hooks/test-tlswrap.js
PR-URL: #14319
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
test: delete obsolete test-sendfd.js
This test was disabled in 2011 and is no longer useful without
modifications.

PR-URL: #14334
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
test: move test-fs-largefile to pummel
test-fs-largefile was disabled. It was fixed in bbf74fb but left in
disabled because it generates a 5Gb file. However, gibfahn had the
sensible suggestion of moving it to the pummel directory. Which is what
this change does.

In pummel, lint rules are applied, so this does necessitate changing a
pair of `var` declarations to `const`.

PR-URL: #14338
Refs: bbf74fb
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
benchmark: add assert map and set benchmarks
PR-URL: #14258
Reviewed-By: Refael Ackermann <refack@gmail.com>
test: add comments for whatwg-url tests
Added comments to whatwg-url tests that they should not be changed until
modifications are merged upstream as per "Web Platform Tests" guidelines

PR-URL: #14355
Fixes: #12793
Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
test: fix flaky test-net-write-after-close
Replace 250ms timer with event-based logic to make test robust.

PR-URL: #14361
Fixes: #13597
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
doc: fix typo in stream.md
PR-URL: #14364
Fixes: #14362
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
doc: error message are still major
PR-URL: #14375
Refs: #13937
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
doc: add XadillaX to collaborators
PR-URL: #14388
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
tools: skip workaround for newer llvm
PR-URL: #14077
Fixes: #14076
Refs: https://svnweb.freebsd.org/ports/head/www/node/Makefile?revision=444555&view=markup
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Refael Ackermann <refack@gmail.com>
tools: always include llvm_version in config
Also used in common.gypi to check whether a flag is needed or not
based on llvm version.

PR-URL: #14077
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Refael Ackermann <refack@gmail.com>
test: move timing-dependent tests to sequential
Move test-http-server-keep-alive-timeout-slow-server and
test-http-server-keep-alive-timeout-slow-client-headers from parallel to
sequential to resolve test flakiness on freebsd10-64.

Fixes: #14033
Refs: #9317
PR-URL: #14377
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
test: replace concatenation with template literals
* test/parallel/test-stdout-close-catch.js

PR-URL: #14298
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
doc: describe labelling process for backports
Based on discussion from the first backporting team meeting.

PR-URL: #12431
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
test: replace concatenation with template literals
Replace string concatenation in test/async-hooks/test-signalwrap.js
with template literals.

PR-URL: #14295
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
deps: cherry-pick 18ea996 from c-ares upstream
Original commit message:

    ares_parse_naptr_reply: make buffer length check more accurate

    9478908a490a6bf009ba58d81de8c1d06d50a117 introduced a length check
    for records parsed by `ares_parse_naptr_reply()`. However, that
    function is designed to parse replies which also contain non-NAPTR
    records; for A records, the `rr_len > 7` check will fail as there
    are only 4 bytes of payload.
    In particular, parsing ANY replies for NAPTR records was broken
    by that patch.

    Fix that by moving the check into the case in which it is already
    known that the record is a NAPTR record.

Ref: c-ares/c-ares@18ea996
PR-URL: #13883
Reviewed-By: James M Snell <jasnell@gmail.com>
test: add non-internet resolveAny tests
This is a bit of a check to see how people feel about having this kind
of test.

Ref: #13137
PR-URL: #13883
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
doc: fix some links
PR-URL: #14400
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>
test: improve test-util-inspect
PR-URL: #14003
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
lib: include cached modules in module.children
`module.children` is supposed to be the list of modules included by this
module but lib/module.js failed to update the list when the included
module was retrieved from `Module._cache`.

Fixes: #7131
PR-URL: #14132
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
n-api: add fast paths for integer getters
Ref: #14379
PR-URL: #14393
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
doc,assert: document stackStartFunction in fail
PR-URL: #13862
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Backport-PR-URL: #14428
Backport-Reviewed-By: Anna Henningsen <anna@addaleax.net>
@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Aug 8, 2017

Contributor

That one will probably have to wait for the next release.

Contributor

cjihrig commented Aug 8, 2017

That one will probably have to wait for the next release.

@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Aug 8, 2017

Member

So the one failure that is really making me uncomfortable is body-parser.

It is now failing across all platforms with that timeout... is there something that has changed so drastically in the perf that this is happening?

Keep in mind that these failures were not present when testing 6.0 against master.

Member

MylesBorins commented Aug 8, 2017

So the one failure that is really making me uncomfortable is body-parser.

It is now failing across all platforms with that timeout... is there something that has changed so drastically in the perf that this is happening?

Keep in mind that these failures were not present when testing 6.0 against master.

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Aug 8, 2017

Member

@MylesBorins I can reproduce locally. v8.2.1 takes ~750 ms for the failing test, master takes ~3 seconds for that test (and ~2 seconds when I’m passing --trace-deopt, confusingly).

Member

addaleax commented Aug 8, 2017

@MylesBorins I can reproduce locally. v8.2.1 takes ~750 ms for the failing test, master takes ~3 seconds for that test (and ~2 seconds when I’m passing --trace-deopt, confusingly).

@evanlucas

This comment has been minimized.

Show comment
Hide comment
@evanlucas

evanlucas Aug 8, 2017

Member

The below does seem to be a little slower on 8.3.0 than it does on 8.1.4, but only by a few

'use strict'

function createManyParams (count) {
  var str = ''

  if (count === 0) {
    return str
  }

  str += '0=0'

  for (var i = 1; i < count; i++) {
    var n = i.toString(36)
    str += '&' + n + '=' + n
  }

  return str
}

console.time(process.version)
createManyParams(10000)
console.timeEnd(process.version)
(D) [/Volumes/code/bench]
:] (v8.1.4) ➜ n use v8.1.4 create-many-params.js                                                                        
v8.1.4: 3.887ms

(D) [/Volumes/code/bench]
:] (v8.1.4) ➜ n use v8.3.0 create-many-params.js                                                                        
v8.3.0-rc.0: 4.628ms

When running the test suite locally for body-parser, that test that is failing takes ~220ms on v8.1.4, but takes ~900ms on 8.3.0 rc0.

Member

evanlucas commented Aug 8, 2017

The below does seem to be a little slower on 8.3.0 than it does on 8.1.4, but only by a few

'use strict'

function createManyParams (count) {
  var str = ''

  if (count === 0) {
    return str
  }

  str += '0=0'

  for (var i = 1; i < count; i++) {
    var n = i.toString(36)
    str += '&' + n + '=' + n
  }

  return str
}

console.time(process.version)
createManyParams(10000)
console.timeEnd(process.version)
(D) [/Volumes/code/bench]
:] (v8.1.4) ➜ n use v8.1.4 create-many-params.js                                                                        
v8.1.4: 3.887ms

(D) [/Volumes/code/bench]
:] (v8.1.4) ➜ n use v8.3.0 create-many-params.js                                                                        
v8.3.0-rc.0: 4.628ms

When running the test suite locally for body-parser, that test that is failing takes ~220ms on v8.1.4, but takes ~900ms on 8.3.0 rc0.

@mcollina

This comment has been minimized.

Show comment
Hide comment
@mcollina
Member

mcollina commented Aug 8, 2017

@evanlucas

This comment has been minimized.

Show comment
Hide comment
@evanlucas

evanlucas Aug 8, 2017

Member

We have been trying to diagnose in #node-dev and just wanted to post here in case anyone else wanted to chime in. This could be completely off track.

Here is a profile from 8.1.4 compared to 8.3.0

v8.1.4: https://gist.github.com/evanlucas/7843a119a7472b498b474af3b63d2a9a
v8.3.0: https://gist.github.com/evanlucas/6759ead0cde37ca0f1a5ecdb19eebf50

It looks like most of the time in 8.3.0 is spent in the ArrayIndexOf builtin which I believe is from https://github.com/nodejs/node/blob/v8.3.0-proposal/lib/querystring.js#L331

/cc @nodejs/v8

Member

evanlucas commented Aug 8, 2017

We have been trying to diagnose in #node-dev and just wanted to post here in case anyone else wanted to chime in. This could be completely off track.

Here is a profile from 8.1.4 compared to 8.3.0

v8.1.4: https://gist.github.com/evanlucas/7843a119a7472b498b474af3b63d2a9a
v8.3.0: https://gist.github.com/evanlucas/6759ead0cde37ca0f1a5ecdb19eebf50

It looks like most of the time in 8.3.0 is spent in the ArrayIndexOf builtin which I believe is from https://github.com/nodejs/node/blob/v8.3.0-proposal/lib/querystring.js#L331

/cc @nodejs/v8

@mcollina

This comment has been minimized.

Show comment
Hide comment
@mcollina

mcollina Aug 8, 2017

Member

There is a fix in #14703.

Member

mcollina commented Aug 8, 2017

There is a fix in #14703.

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack Aug 9, 2017

Member

I can confirm that except for body-parser there's nothing in the CitGM run that we haven't seen before. Either in V8@5.9 or V8@6.0, (discussed briefly in #14574 (comment)).
AFAICT there are no obvious failures, just timeouts (some maybe hangs, but it is still inconclusive).

If coupled with the planned media push announcing that this is a big change in V8, I hope people will know to expect timing/performance surprises.

it's a new dawn
it's a new day
it's a new pipeline
and I'm feeling good

Member

refack commented Aug 9, 2017

I can confirm that except for body-parser there's nothing in the CitGM run that we haven't seen before. Either in V8@5.9 or V8@6.0, (discussed briefly in #14574 (comment)).
AFAICT there are no obvious failures, just timeouts (some maybe hangs, but it is still inconclusive).

If coupled with the planned media push announcing that this is a big change in V8, I hope people will know to expect timing/performance surprises.

it's a new dawn
it's a new day
it's a new pipeline
and I'm feeling good

@bricss

This comment has been minimized.

Show comment
Hide comment
@bricss

bricss Aug 9, 2017

Another delay for a week? 🐌

bricss commented Aug 9, 2017

Another delay for a week? 🐌

@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Aug 9, 2017

Contributor

I can still cut the release today if #14703 lands.

Contributor

cjihrig commented Aug 9, 2017

I can still cut the release today if #14703 lands.

addaleax and others added some commits Aug 2, 2017

child_process: fix handle passing w large payloads
Fix situations in which the handle passed along with a message
that has a large payload and can’t be read entirely by a single
`recvmsg()` call isn’t associated with the message to which it
belongs.

PR-URL: #14588
Fixes: #13778
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
zlib: fix crash when initializing failed
Unset `mode_` when initializing the zlib stream failed, so that
we don’t try to call the zlib end functions (`deflateEnd()` etc.)
when cleaning up in `ZCtx::Close()`.

Fixes: #14178
Ref: #13098
PR-URL: #14666
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
querystring: avoid indexOf when parsing
Fixes a performance regression in body-parser with V8 6.0.
Removes the use of an auxiliary array, and just query the object
directly.

PR-URL: #14703
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
doc: add gabrielschulhof to collaborators
PR-URL: #14692
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2017-08-09, Version 8.3.0 (Current)
V8 6.0:

  The V8 engine has been upgraded to version 6.0, which has a significantly
  changed performance profile.
  [#14574](#14574)

  More detailed information on performance differences can be found at
  https://medium.com/the-node-js-collection/get-ready-a-new-v8-is-coming-node-js-performance-is-changing-46a63d6da4de

Other notable changes:

* **DNS**
  * Independent DNS resolver instances are supported now, with support for
    cancelling the corresponding requests.
    [#14518](#14518)

* **N-API**
  * Multiple N-API functions for error handling have been changed to support
    assigning error codes.
    [#13988](#13988)

* **REPL**
  * Autocompletion support for `require()` has been improved.
    [#14409](#14409)

* **Utilities**
  * The WHATWG Encoding Standard (`TextDecoder` and `TextEncoder`) has
    been implemented as an experimental feature.
    [#13644](#13644)

* **Added new collaborators**
  * [XadillaX](https://github.com/XadillaX) – Khaidi Chu
  * [gabrielschulhof](https://github.com/gabrielschulhof) – Gabriel Schulhof
@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Aug 9, 2017

Member

I’ve updated this PR with all remaining PRs that contain fixes for confirmed bugs/regressions, including #14703 , plus ad901ed because it’s harmless and fits in well as a notable change.

I’m not sure what to do given that CI isn’t up. A local make test passes, though.

Member

addaleax commented Aug 9, 2017

I’ve updated this PR with all remaining PRs that contain fixes for confirmed bugs/regressions, including #14703 , plus ad901ed because it’s harmless and fits in well as a notable change.

I’m not sure what to do given that CI isn’t up. A local make test passes, though.

@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Aug 9, 2017

Contributor

Kicked off the release CI with the new changes.

Contributor

cjihrig commented Aug 9, 2017

Kicked off the release CI with the new changes.

@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Aug 9, 2017

Member

We should hold off on a release until we can test with Ci + Citgm

Member

MylesBorins commented Aug 9, 2017

We should hold off on a release until we can test with Ci + Citgm

@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Aug 9, 2017

Contributor

Agreed. But the ARM release job is still running, so I'm glad I kicked it off when I did. Any word on the CI?

Contributor

cjihrig commented Aug 9, 2017

Agreed. But the ARM release job is still running, so I'm glad I kicked it off when I did. Any word on the CI?

@evanlucas

LGTM if ci is happy

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Aug 10, 2017

Member

CITGM looks good (although AIX failed completely), CI is not exactly green and has a couple flaky tests + infra failures but nothing new or concerning (imo) :shipit: (one ARM machine is still running right now)

Member

addaleax commented Aug 10, 2017

CITGM looks good (although AIX failed completely), CI is not exactly green and has a couple flaky tests + infra failures but nothing new or concerning (imo) :shipit: (one ARM machine is still running right now)

@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Aug 10, 2017

Contributor

@MylesBorins are you able to sign off on this?

Contributor

cjihrig commented Aug 10, 2017

@MylesBorins are you able to sign off on this?

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack Aug 10, 2017

Member

The node-iconv CitGM showed on windows does not repro locally.

Member

refack commented Aug 10, 2017

The node-iconv CitGM showed on windows does not repro locally.

@refack

refack approved these changes Aug 10, 2017

CitGM is clean (i.e. no new failures)

@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Aug 10, 2017

Member

Quick follow up on CITGM

Three modules seem legitimately broken right now, a few more seem flaky (not sure if it is our CI systems or the modules themselves.)

It doesn't appear that anything major is broken with this release.

  • yeoman-generator: not broken by this release (broken since 8.0.0). Will dig in more
  • ref: broken by changes to garbage collection opened issue
  • ffi: been broken for a while, fix is pr'd node-ffi/node-ffi#380
Member

MylesBorins commented Aug 10, 2017

Quick follow up on CITGM

Three modules seem legitimately broken right now, a few more seem flaky (not sure if it is our CI systems or the modules themselves.)

It doesn't appear that anything major is broken with this release.

  • yeoman-generator: not broken by this release (broken since 8.0.0). Will dig in more
  • ref: broken by changes to garbage collection opened issue
  • ffi: been broken for a while, fix is pr'd node-ffi/node-ffi#380
@MylesBorins

LGTM

Working on v8.3.1
PR-URL: #14594
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>

@cjihrig cjihrig merged commit 08b662a into v8.x Aug 10, 2017

@cjihrig cjihrig deleted the v8.3.0-proposal branch Aug 10, 2017

cjihrig added a commit to cjihrig/nodejs.org that referenced this pull request Aug 10, 2017

@cjihrig cjihrig referenced this pull request Aug 10, 2017

Merged

Blog: v8.3.0 release post #1334

cjihrig added a commit to nodejs/nodejs.org that referenced this pull request Aug 10, 2017

@vsemozhetbyt

This comment has been minimized.

Show comment
Hide comment
@vsemozhetbyt

vsemozhetbyt Aug 10, 2017

Member

RE nodejs/nodejs.org#1334: are not "add console.count() and console.clear()" notable changes?

Member

vsemozhetbyt commented Aug 10, 2017

RE nodejs/nodejs.org#1334: are not "add console.count() and console.clear()" notable changes?

@kyrylkov

This comment has been minimized.

Show comment
Hide comment
@kyrylkov

kyrylkov Aug 10, 2017

@addaleax @cjihrig are spread properties for object literals not supported in v8.3.0?

kyrylkov commented Aug 10, 2017

@addaleax @cjihrig are spread properties for object literals not supported in v8.3.0?

@vsemozhetbyt

This comment has been minimized.

Show comment
Hide comment
@vsemozhetbyt

vsemozhetbyt Aug 10, 2017

Member

@kyrylkov Supported:

> process.versions.node
'8.3.0'
> process.versions.v8
'6.0.286.52'
> const { key1, ...rest } = { key1: 1, key2: 2, key3: 3 };
undefined
> rest
{ key2: 2, key3: 3 }
> const copy = { key1: 1, ...rest };
undefined
> copy
{ key1: 1, key2: 2, key3: 3 }

Refs: https://v8project.blogspot.com/2017/06/v8-release-60.html

Member

vsemozhetbyt commented Aug 10, 2017

@kyrylkov Supported:

> process.versions.node
'8.3.0'
> process.versions.v8
'6.0.286.52'
> const { key1, ...rest } = { key1: 1, key2: 2, key3: 3 };
undefined
> rest
{ key2: 2, key3: 3 }
> const copy = { key1: 1, ...rest };
undefined
> copy
{ key1: 1, key2: 2, key3: 3 }

Refs: https://v8project.blogspot.com/2017/06/v8-release-60.html

@kyrylkov

This comment has been minimized.

Show comment
Hide comment
@kyrylkov

kyrylkov Aug 10, 2017

@vsemozhetbyt Yep, sorry. babel-node issue.

> process.versions.node
'8.3.0'
> process.versions.v8
'6.0.286.52'
> const { key1, ...rest } = { key1: 1, key2: 2, key3: 3 };
SyntaxError: repl: Unexpected token (1:14)
> 1 | const { key1, ...rest } = { key1: 1, key2: 2, key3: 3 };
    |               ^

kyrylkov commented Aug 10, 2017

@vsemozhetbyt Yep, sorry. babel-node issue.

> process.versions.node
'8.3.0'
> process.versions.v8
'6.0.286.52'
> const { key1, ...rest } = { key1: 1, key2: 2, key3: 3 };
SyntaxError: repl: Unexpected token (1:14)
> 1 | const { key1, ...rest } = { key1: 1, key2: 2, key3: 3 };
    |               ^
@mhdawson

This comment has been minimized.

Show comment
Hide comment
@mhdawson

mhdawson Aug 14, 2017

Member

A bit late but I agree changing the N-API version is not necessary quite yet.

Member

mhdawson commented Aug 14, 2017

A bit late but I agree changing the N-API version is not necessary quite yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment