New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: read proper inspector message size #14596

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
10 participants
@bzoz
Contributor

bzoz commented Aug 2, 2017

Fix a bug when messages bigger than 64kb where incorrectly parsed by the inspector-helper.
See #14507 (comment)

Fixes: #14507

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

/cc @eugeneo @nodejs/v8-inspector

test: read proper inspector message size
Fix a bug when messages bigger than 64kb where incorrectly parsed by
the inspector-helper.

Fixes: #14507
@bzoz

This comment has been minimized.

Show comment
Hide comment
@bzoz

bzoz Aug 2, 2017

Contributor

I've added a test for max message size, PTAL

Contributor

bzoz commented Aug 2, 2017

I've added a test for max message size, PTAL

@lpinca

lpinca approved these changes Aug 2, 2017

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Aug 2, 2017

Member

CI: https://ci.nodejs.org/job/node-test-pull-request/9451/

Only failure is build/infra related. CI is effectively green.

Member

Trott commented Aug 2, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/9451/

Only failure is build/infra related. CI is effectively green.

@eugeneo

eugeneo approved these changes Aug 2, 2017

@refack

refack approved these changes Aug 2, 2017

LGTM % nits

Show outdated Hide outdated test/inspector/inspector-helper.js
@cjihrig

cjihrig approved these changes Aug 3, 2017

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Aug 3, 2017

Member

Given the frequency that the test is failing on CI, I'd like to land this now-ish. Anyone else feel the same?

Member

Trott commented Aug 3, 2017

Given the frequency that the test is failing on CI, I'd like to land this now-ish. Anyone else feel the same?

@bzoz

This comment has been minimized.

Show comment
Hide comment
@bzoz

bzoz Aug 4, 2017

Contributor

I've fixed the spelling, changed assert per @jasnell suggestion and added @refack link, PTAL

Contributor

bzoz commented Aug 4, 2017

I've fixed the spelling, changed assert per @jasnell suggestion and added @refack link, PTAL

@bzoz

This comment has been minimized.

Show comment
Hide comment
@bzoz

bzoz Aug 4, 2017

Contributor

CI (its still "pending", I think this is the correct one): https://ci.nodejs.org/job/node-test-pull-request/9483/

Contributor

bzoz commented Aug 4, 2017

CI (its still "pending", I think this is the correct one): https://ci.nodejs.org/job/node-test-pull-request/9483/

@refack

refack approved these changes Aug 4, 2017

@jasnell

jasnell approved these changes Aug 4, 2017

@refack

This comment has been minimized.

Show comment
Hide comment
@refack
Member

refack commented Aug 4, 2017

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Aug 4, 2017

Member

Only failure in CI is a known flaky unrelated to this. CI is effectively green. Landing...

Member

Trott commented Aug 4, 2017

Only failure in CI is a known flaky unrelated to this. CI is effectively green. Landing...

Trott added a commit to Trott/io.js that referenced this pull request Aug 4, 2017

test: read proper inspector message size
Fix a bug when messages bigger than 64kb where incorrectly parsed by
the inspector-helper.

PR-URL: nodejs#14596
Fixes: nodejs#14507
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Aug 4, 2017

Member

Landed in 2dc09f6. 🎉

Member

Trott commented Aug 4, 2017

Landed in 2dc09f6. 🎉

@Trott Trott closed this Aug 4, 2017

@refack

This comment has been minimized.

Show comment
Hide comment
@refack
Member

refack commented Aug 4, 2017

AIX fail is a known flake and is unrelated #14599 -
https://ci.nodejs.org/job/node-test-commit-aix/7643/nodes=aix61-ppc64/

@MylesBorins MylesBorins referenced this pull request Aug 8, 2017

Merged

v8.3.0 proposal #14594

addaleax added a commit that referenced this pull request Aug 10, 2017

test: read proper inspector message size
Fix a bug when messages bigger than 64kb where incorrectly parsed by
the inspector-helper.

PR-URL: #14596
Fixes: #14507
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@addaleax addaleax referenced this pull request Aug 13, 2017

Merged

v8.4.0 proposal #14811

MylesBorins added a commit that referenced this pull request Sep 19, 2017

test: read proper inspector message size
Fix a bug when messages bigger than 64kb where incorrectly parsed by
the inspector-helper.

PR-URL: #14596
Fixes: #14507
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Sep 19, 2017

test: read proper inspector message size
Fix a bug when messages bigger than 64kb where incorrectly parsed by
the inspector-helper.

PR-URL: #14596
Fixes: #14507
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Sep 20, 2017

Merged

v6.11.4 proposal #15506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment