Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
os: make EOL configurable and readonly #14622
I’ve removed my Changes Requested label, but as I mentioned I don’t quite see the point here.
Maybe it’s a miscommunication about what “constant” means in this context; if documentation for JS code says that
referenced this pull request
Aug 13, 2017
-0. In general I'm not sure it's a good idea to make properties like this non-configurable, because it removes an escape hatch. I can imagine a hypothetical test helper to verify an that application works on multiple platforms, which could rely on mutating
If we're convinced that we want to make the property non-writable to avoid accidental mutation, could we keep the property configurable? That way it would still be possible to overwrite the property as an escape hatch, but users would be unlikely to mutate it by mistake.
edit: I just saw that it is configurable the current version of the PR. The title of the PR still says it's non-configurable.
I count 4