New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

string_decoder: Migrate to use internal/errors #14682

Closed
wants to merge 1 commit into
base: master
from

Conversation

@starkwang
Contributor

starkwang commented Aug 8, 2017

Ref: #11273

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

string_decoder

@refack

refack approved these changes Aug 8, 2017

@refack refack self-assigned this Aug 8, 2017

@jasnell jasnell referenced this pull request Aug 8, 2017

Closed

Tracking Issue: Migrate errors to internal/errors.js #11273

78 of 80 tasks complete
@refack

This comment has been minimized.

Show comment
Hide comment
Show outdated Hide outdated lib/string_decoder.js Outdated
@targos

targos approved these changes Aug 8, 2017

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack Aug 8, 2017

Member

ping @nodejs/ctc, needs approval

Member

refack commented Aug 8, 2017

ping @nodejs/ctc, needs approval

@mcollina

This comment has been minimized.

Show comment
Hide comment
@mcollina

mcollina Aug 8, 2017

Member

We ship this in readable-stream as part of http://npm.im/string_decoder. We need the same solution that we will need for the streams.

Can we hold off until that is ready? I would prefer not having to revert too many commits before releasing 9 if that is not ready.

cc @jasnell

Member

mcollina commented Aug 8, 2017

We ship this in readable-stream as part of http://npm.im/string_decoder. We need the same solution that we will need for the streams.

Can we hold off until that is ready? I would prefer not having to revert too many commits before releasing 9 if that is not ready.

cc @jasnell

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack Aug 8, 2017

Member

blocked until we have a modular solution for readable-stream

Member

refack commented Aug 8, 2017

blocked until we have a modular solution for readable-stream

@refack refack added this to In Progress in Error Codes Aug 20, 2017

@mcollina mcollina removed the blocked label Sep 12, 2017

@mcollina

This comment has been minimized.

Show comment
Hide comment
@mcollina

mcollina Sep 12, 2017

Member

At the latest streams wg we decided to unblock this. We would like this (and the equals for Writable, Duplex and Transform) to ship in Node 9.

Ref: nodejs/readable-stream#309 (comment)

Member

mcollina commented Sep 12, 2017

At the latest streams wg we decided to unblock this. We would like this (and the equals for Writable, Duplex and Transform) to ship in Node 9.

Ref: nodejs/readable-stream#309 (comment)

@mcollina

LGTM if CI green.

@BridgeAR

This comment has been minimized.

Show comment
Hide comment
@BridgeAR

BridgeAR Sep 13, 2017

Member

Landed in eb4940e

Member

BridgeAR commented Sep 13, 2017

Landed in eb4940e

@BridgeAR BridgeAR closed this Sep 13, 2017

BridgeAR added a commit that referenced this pull request Sep 13, 2017

string_decoder: Migrate to use internal/errors
PR-URL: #14682
Refs: #11273
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

addaleax added a commit to addaleax/ayo that referenced this pull request Sep 17, 2017

string_decoder: Migrate to use internal/errors
PR-URL: nodejs/node#14682
Refs: nodejs/node#11273
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Qard pushed a commit to Qard/ayo that referenced this pull request Sep 21, 2017

string_decoder: Migrate to use internal/errors
PR-URL: nodejs/node#14682
Refs: nodejs/node#11273
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@jasnell jasnell moved this from In Progress to Done in Error Codes Oct 25, 2017

@refack refack removed their assignment Oct 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment