Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_http_outgoing: migrate to use internal/errors #14735

Closed

Conversation

@starkwang
Copy link
Contributor

@starkwang starkwang commented Aug 10, 2017

Ref: #11273

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

http, errors

Copy link
Member

@jasnell jasnell left a comment

LGTM with green CI

@refack refack self-assigned this Aug 12, 2017
@jasnell jasnell mentioned this pull request Aug 12, 2017
79 of 80 tasks complete
@refack
refack approved these changes Aug 12, 2017
common.expectsError(
() => res.setHeader(),
{
code: 'ERR_INVALID_HTTP_TOKEN',

This comment has been minimized.

@refack

refack Aug 12, 2017
Member

@starkwang how much work will it to add the given value (in addition to the token name)?

This comment has been minimized.

@starkwang

starkwang Aug 13, 2017
Author Contributor

I've added some more information about the given value in the error message.

@starkwang starkwang force-pushed the starkwang:http-outgoing-internal-errors branch to 0fcece2 Aug 13, 2017
@starkwang starkwang mentioned this pull request Aug 13, 2017
3 of 3 tasks complete
@refack
refack approved these changes Aug 13, 2017
Copy link
Member

@refack refack left a comment

💯

@refack
Copy link
Member

@refack refack commented Aug 13, 2017

Copy link
Member

@mhdawson mhdawson left a comment

LGTM, thanks !

@refack
Copy link
Member

@refack refack commented Aug 14, 2017

Landed in 11a2ca2
(had a green CI from 23h ago)

@refack refack closed this Aug 14, 2017
refack added a commit that referenced this pull request Aug 14, 2017
PR-URL: #14735
Refs: #11273
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@refack refack added this to Done in Error Codes Aug 20, 2017
@refack refack removed their assignment Oct 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Error Codes
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.