New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_http_outgoing: migrate to use internal/errors #14735

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
5 participants
@starkwang
Contributor

starkwang commented Aug 10, 2017

Ref: #11273

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

http, errors

@jasnell

LGTM with green CI

@refack refack self-assigned this Aug 12, 2017

@jasnell jasnell referenced this pull request Aug 12, 2017

Closed

Tracking Issue: Migrate errors to internal/errors.js #11273

78 of 80 tasks complete
@refack

refack approved these changes Aug 12, 2017

common.expectsError(
() => res.setHeader(),
{
code: 'ERR_INVALID_HTTP_TOKEN',

This comment has been minimized.

@refack

refack Aug 12, 2017

Member

@starkwang how much work will it to add the given value (in addition to the token name)?

@refack

refack Aug 12, 2017

Member

@starkwang how much work will it to add the given value (in addition to the token name)?

This comment has been minimized.

@starkwang

starkwang Aug 13, 2017

Contributor

I've added some more information about the given value in the error message.

@starkwang

starkwang Aug 13, 2017

Contributor

I've added some more information about the given value in the error message.

@starkwang starkwang referenced this pull request Aug 13, 2017

Closed

http: be more specific when reporting errors #14759

3 of 3 tasks complete
@refack

refack approved these changes Aug 13, 2017

💯

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

This comment has been minimized.

Show comment
Hide comment
@refack
Member

refack commented Aug 13, 2017

@mhdawson

LGTM, thanks !

@mhdawson

This comment has been minimized.

Show comment
Hide comment
Member

mhdawson commented Aug 14, 2017

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack Aug 14, 2017

Member

Landed in 11a2ca2
(had a green CI from 23h ago)

Member

refack commented Aug 14, 2017

Landed in 11a2ca2
(had a green CI from 23h ago)

@refack refack closed this Aug 14, 2017

refack added a commit that referenced this pull request Aug 14, 2017

errors: migrate _http_outgoing
PR-URL: #14735
Refs: #11273
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

@refack refack added this to Done in Error Codes Aug 20, 2017

@refack refack removed their assignment Oct 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment