GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make -j4 test
LGTM with green CI
@starkwang how much work will it to add the given value (in addition to the token name)?
I've added some more information about the given value in the error message.
_http_outgoing: migrate to use internal/errors
/cc @mcollina @mhdawson @fhinkel
LGTM, thanks !
CI run: https://ci.nodejs.org/job/node-test-pull-request/9660/
Landed in 11a2ca2
(had a green CI from 23h ago)
errors: migrate _http_outgoing
Reviewed-By: James M Snell <email@example.com>
Reviewed-By: Refael Ackermann <firstname.lastname@example.org>
Reviewed-By: Michael Dawson <email@example.com>