Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
url: drop auth in `url.resolve()` if host changes #1480
I don't think it should copy over. However, to change that would be
> var parsed = url.parse('mailto:email@example.com'); undefined > parsed.host = 'example.com'; 'example.com' > url.format(parsed); 'mailto:firstname.lastname@example.org'
Looks like this was never resolved. There's really no question that the user id and password should not be getting copied over..
referenced this pull request
Nov 18, 2015
@nodejs/ctc ... amazingly, this PR was opened a year ago and still applies cleanly (albeit using a three way merge). It even passes linting! The change LGTM.
marked it semver-major because it changes the behavior of url.resolve to drop the auth but it could also be classified as a bug fix. PTAL