New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve assertion fail messages #14949

Closed
wants to merge 2 commits into
base: master
from

Conversation

@refack
Member

refack commented Aug 19, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@refack

This comment has been minimized.

Show comment
Hide comment

@refack refack self-assigned this Aug 19, 2017

@bjouhier

This comment has been minimized.

Show comment
Hide comment
@bjouhier

bjouhier Aug 19, 2017

Contributor

does not inherits -> does not inherit (3 occurrences)

Contributor

bjouhier commented Aug 19, 2017

does not inherits -> does not inherit (3 occurrences)

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack Aug 19, 2017

Member

does not inherits -> does not inherit (3 occurrences)

Fixed

Member

refack commented Aug 19, 2017

does not inherits -> does not inherit (3 occurrences)

Fixed

@refack

This comment has been minimized.

Show comment
Hide comment
@lpinca

lpinca approved these changes Aug 20, 2017

jasnell added a commit that referenced this pull request Aug 23, 2017

test: improve assertion fail messages
PR-URL: #14949
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 23, 2017

Member

Landed in 0ce54a7

Member

jasnell commented Aug 23, 2017

Landed in 0ce54a7

@jasnell jasnell closed this Aug 23, 2017

addaleax added a commit to addaleax/ayo that referenced this pull request Aug 25, 2017

test: improve assertion fail messages
PR-URL: nodejs/node#14949
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax added a commit to ayojs/ayo that referenced this pull request Aug 28, 2017

test: improve assertion fail messages
PR-URL: nodejs/node#14949
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Sep 10, 2017

test: improve assertion fail messages
PR-URL: #14949
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Sep 10, 2017

Merged

v8.5.0 proposal #15308

MylesBorins added a commit that referenced this pull request Sep 12, 2017

test: improve assertion fail messages
PR-URL: #14949
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Sep 20, 2017

test: improve assertion fail messages
PR-URL: #14949
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Sep 20, 2017

Merged

v6.11.4 proposal #15506

@refack refack deleted the refack:tweak-test-stream-inheritance branch Sep 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment