New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to correct "OS Constants" heading in docs #14969

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
8 participants
@jamiebuilds
Contributor

jamiebuilds commented Aug 21, 2017

There are two sections with the name "os(.)constants", the link from inside # os.constants means to link to # OS Constants but its hash is os_os_constants_1 so right now its linking to itself.

Show outdated Hide outdated doc/api/os.md
@lpinca

lpinca approved these changes Aug 22, 2017

Comment addressed

jasnell added a commit that referenced this pull request Aug 23, 2017

doc: link to correct "OS Constants" heading in docs
PR-URL: #14969
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 23, 2017

Member

Landed in 954b346

Member

jasnell commented Aug 23, 2017

Landed in 954b346

@jasnell jasnell closed this Aug 23, 2017

addaleax added a commit to addaleax/ayo that referenced this pull request Aug 25, 2017

doc: link to correct "OS Constants" heading in docs
PR-URL: nodejs/node#14969
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

addaleax added a commit to ayojs/ayo that referenced this pull request Aug 28, 2017

doc: link to correct "OS Constants" heading in docs
PR-URL: nodejs/node#14969
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins added a commit that referenced this pull request Sep 10, 2017

doc: link to correct "OS Constants" heading in docs
PR-URL: #14969
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@MylesBorins MylesBorins referenced this pull request Sep 10, 2017

Merged

v8.5.0 proposal #15308

MylesBorins added a commit that referenced this pull request Sep 12, 2017

doc: link to correct "OS Constants" heading in docs
PR-URL: #14969
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins added a commit that referenced this pull request Sep 20, 2017

doc: link to correct "OS Constants" heading in docs
PR-URL: #14969
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@MylesBorins MylesBorins referenced this pull request Sep 20, 2017

Merged

v6.11.4 proposal #15506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment