New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: merge TSC and CTC back into a single body #14973

Closed
wants to merge 1 commit into
base: master
from

Conversation

@jasnell
Member

jasnell commented Aug 22, 2017

Merge the CTC and TSC back into a single body. Dependent on approval and landing of nodejs/TSC#317

/cc @nodejs/ctc @nodejs/tsc

@mcollina

This comment has been minimized.

Show comment
Hide comment
@mcollina

mcollina Aug 22, 2017

Member

LGTM

Member

mcollina commented Aug 22, 2017

LGTM

@indutny

This comment has been minimized.

Show comment
Hide comment
@indutny

indutny Aug 22, 2017

Member

LGTM

Member

indutny commented Aug 22, 2017

LGTM

@ChALkeR

There are conflicts between the procedure here and as defined in the TSC repo (and charter). Those probably need to be resolved.

I highlighted via inline comments the ones that I noticed, there could be more.

Show outdated Hide outdated GOVERNANCE.md
Show outdated Hide outdated GOVERNANCE.md
Show outdated Hide outdated GOVERNANCE.md
@ChALkeR

This comment has been minimized.

Show comment
Hide comment
@ChALkeR

ChALkeR Aug 22, 2017

Member

Overall, I am in favor of this, but currently there are conflicts that need to be resolved.

Member

ChALkeR commented Aug 22, 2017

Overall, I am in favor of this, but currently there are conflicts that need to be resolved.

@gireeshpunathil

Clarity in organizational hierarchy and coherence in roles & responsibilities - sounds great to me.

Issues mentioned in the review are fixed not

@ChALkeR

This comment has been minimized.

Show comment
Hide comment
@ChALkeR

ChALkeR Aug 22, 2017

Member

Argh, I can't edit the dismiss message. s/not/now/ in my message, sorry =).

Member

ChALkeR commented Aug 22, 2017

Argh, I can't edit the dismiss message. s/not/now/ in my message, sorry =).

@Fishrock123

This comment has been minimized.

Show comment
Hide comment
@Fishrock123

Fishrock123 Aug 22, 2017

Member

I am in favor of this.

Member

Fishrock123 commented Aug 22, 2017

I am in favor of this.

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 22, 2017

Member

@Fishrock123 ... does that count as signoff? If so, can I ask you to please use the Approve/Request Changes workflow as a clearer indication.

Member

jasnell commented Aug 22, 2017

@Fishrock123 ... does that count as signoff? If so, can I ask you to please use the Approve/Request Changes workflow as a clearer indication.

Show outdated Hide outdated COLLABORATOR_GUIDE.md
Show outdated Hide outdated README.md
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 22, 2017

Member

@evanlucas ... updated

Member

jasnell commented Aug 22, 2017

@evanlucas ... updated

@evanlucas

LGTM with a nit

Show outdated Hide outdated GOVERNANCE.md

@jasnell jasnell requested review from nodejs/tsc Aug 22, 2017

@@ -65,109 +66,60 @@ including:
* Conduct guidelines
* Maintaining the list of additional Collaborators
* [Current list of CTC members](./README.md#current-project-team-members)
* [Current list of TSC members](./README.md#current-project-team-members)

This comment has been minimized.

@Trott

Trott Aug 22, 2017

Member

Micro-nit: The link should probably go to ./README.md#tsc-core-technical-committee which will link to the same place as https://github.com/nodejs/node#ctc-core-technical-committee one the ctc is changed to tsc in the README doc. Totally not a blocking objection, just a tiny suggestion.

@Trott

Trott Aug 22, 2017

Member

Micro-nit: The link should probably go to ./README.md#tsc-core-technical-committee which will link to the same place as https://github.com/nodejs/node#ctc-core-technical-committee one the ctc is changed to tsc in the README doc. Totally not a blocking objection, just a tiny suggestion.

YouTube.
Items are added to the CTC agenda which are considered contentious or
are modifications of governance, contribution policy, CTC membership,
Items are added to the TSC agenda which are considered contentious or

This comment has been minimized.

@Trott

Trott Aug 22, 2017

Member

This paragraph is now redundant because it contains information already included in the TSC Charter. It's still good to have it here, I think, but it may be worth including a sentence somewhere in this doc that notes that if anything written in this doc is in contradiction with something in the TSC Charter, the TSC Charter takes precedence.

@Trott

Trott Aug 22, 2017

Member

This paragraph is now redundant because it contains information already included in the TSC Charter. It's still good to have it here, I think, but it may be worth including a sentence somewhere in this doc that notes that if anything written in this doc is in contradiction with something in the TSC Charter, the TSC Charter takes precedence.

This comment has been minimized.

@Trott

Trott Aug 22, 2017

Member

(Also, that's another Totally Non-Blocking Suggestion.)

@Trott

Trott Aug 22, 2017

Member

(Also, that's another Totally Non-Blocking Suggestion.)

This comment has been minimized.

@jasnell

jasnell Aug 22, 2017

Member

That can be handled in a separate PR.

@jasnell

jasnell Aug 22, 2017

Member

That can be handled in a separate PR.

@@ -510,7 +514,7 @@ Previous releases may also have been signed with one of the following GPG keys:
### Working Groups
Information on the current Node.js Working Groups can be found in the
[CTC repository](https://github.com/nodejs/CTC/blob/master/WORKING_GROUPS.md).
[TSC repository](https://github.com/nodejs/TSC/blob/master/WORKING_GROUPS.md).

This comment has been minimized.

@Trott

Trott Aug 22, 2017

Member

This change means we'll need to merge the two WORKING_GROUPS.md docs. If anyone's feeling ambitious and wants to open a PR against the TSC repo to have that ready to go, that would be awesome. (Non-blocking, just pointing out something that someone may choose to act on at this time or not.)

@Trott

Trott Aug 22, 2017

Member

This change means we'll need to merge the two WORKING_GROUPS.md docs. If anyone's feeling ambitious and wants to open a PR against the TSC repo to have that ready to go, that would be awesome. (Non-blocking, just pointing out something that someone may choose to act on at this time or not.)

This comment has been minimized.

@jasnell

jasnell Aug 22, 2017

Member

Yes, the corresponding PR against the TSC repo already does that.

@jasnell

jasnell Aug 22, 2017

Member

Yes, the corresponding PR against the TSC repo already does that.

@Trott

Trott approved these changes Aug 22, 2017

jasnell added a commit that referenced this pull request Aug 29, 2017

meta: merge TSC and CTC back into a single body
PR-URL: #14973
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 29, 2017

Member

Landed in f3eb193

Member

jasnell commented Aug 29, 2017

Landed in f3eb193

@jasnell jasnell closed this Aug 29, 2017

@sam-github

This comment has been minimized.

Show comment
Hide comment
@sam-github

sam-github Aug 29, 2017

Member

Is there going to be a CTC meeting tomorrow morning?

Member

sam-github commented Aug 29, 2017

Is there going to be a CTC meeting tomorrow morning?

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 29, 2017

Member

Yep, the CTC meeting schedule doesn't change.

Member

jasnell commented Aug 29, 2017

Yep, the CTC meeting schedule doesn't change.

oe added a commit to ayojs/ayo that referenced this pull request Aug 30, 2017

meta: merge TSC and CTC back into a single body
PR-URL: nodejs/node#14973
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>

oe added a commit to ayojs/ayo that referenced this pull request Aug 30, 2017

meta: merge TSC and CTC back into a single body
PR-URL: nodejs/node#14973
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>

cjihrig added a commit to cjihrig/node-1 that referenced this pull request Aug 31, 2017

meta: merge TSC and CTC back into a single body
PR-URL: nodejs#14973
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>

MylesBorins added a commit that referenced this pull request Sep 10, 2017

meta: merge TSC and CTC back into a single body
PR-URL: #14973
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>

@MylesBorins MylesBorins referenced this pull request Sep 10, 2017

Merged

v8.5.0 proposal #15308

MylesBorins added a commit that referenced this pull request Sep 12, 2017

meta: merge TSC and CTC back into a single body
PR-URL: #14973
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>

MylesBorins added a commit that referenced this pull request Sep 20, 2017

meta: merge TSC and CTC back into a single body
PR-URL: #14973
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>

@MylesBorins MylesBorins referenced this pull request Sep 20, 2017

Merged

v6.11.4 proposal #15506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment