New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buffer: improve error messages #14975

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@starkwang
Contributor

starkwang commented Aug 22, 2017

Some errors in buffer module losed some arguments or received wrong arguments when they were created. This PR added these losing arguments and fixed the wrong arguments.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

buffer, test

buffer: improve error messages
Some errors in buffer module losed some arguments or received
wrong arguments when they were created. This PR added these
losing arguments and fixed the wrong arguments.
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 22, 2017

Member

@nodejs/ctc ... did we resolve whether we wanted to treat these kinds of changes as semver-major still?

Member

jasnell commented Aug 22, 2017

@nodejs/ctc ... did we resolve whether we wanted to treat these kinds of changes as semver-major still?

@mcollina

LGTM they are still semver-major until further notice.

@mcollina

This comment has been minimized.

Show comment
Hide comment
@jasnell

This comment has been minimized.

Show comment
Hide comment
Member

jasnell commented Aug 24, 2017

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 24, 2017

Member

CI is good. Landing

Member

jasnell commented Aug 24, 2017

CI is good. Landing

jasnell added a commit that referenced this pull request Aug 24, 2017

buffer: improve error messages
Some errors in buffer module losed some arguments or received
wrong arguments when they were created. This PR added these
losing arguments and fixed the wrong arguments.

PR-URL: #14975
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 24, 2017

Member

Landed in 9e0f771

Member

jasnell commented Aug 24, 2017

Landed in 9e0f771

@jasnell jasnell closed this Aug 24, 2017

addaleax added a commit to addaleax/ayo that referenced this pull request Aug 25, 2017

buffer: improve error messages
Some errors in buffer module losed some arguments or received
wrong arguments when they were created. This PR added these
losing arguments and fixed the wrong arguments.

PR-URL: nodejs/node#14975
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

addaleax added a commit to ayojs/ayo that referenced this pull request Aug 28, 2017

buffer: improve error messages
Some errors in buffer module losed some arguments or received
wrong arguments when they were created. This PR added these
losing arguments and fixed the wrong arguments.

PR-URL: nodejs/node#14975
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment