New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix typo in Buffer.from(string, [encoding]) #15013

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@Ginden
Contributor

Ginden commented Aug 24, 2017

Checklist
Affected core subsystem(s)

doc

@jasnell

this should not need to wait the 48 hours to land :-)

@joyeecheung

This comment has been minimized.

Member

joyeecheung commented Aug 24, 2017

@Ginden Looks like you have accidentally pushed commits fixing tests to this PR?

@jscissr jscissr referenced this pull request Aug 24, 2017

Closed

doc,stream: remove wrong remark on readable.read #15014

2 of 2 tasks complete
@Ginden

This comment has been minimized.

Contributor

Ginden commented Aug 24, 2017

@joyeecheung It seems like history on nodejs/node was rebased and it's artifact.

Fixed.

@joyeecheung

This comment has been minimized.

Member

joyeecheung commented Aug 24, 2017

Landed in abced13. Thanks for your contribution and welcome to Node.js!

joyeecheung added a commit that referenced this pull request Aug 24, 2017

doc: fix typo in Buffer.from(string, [encoding])
PR-URL: #15013
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

addaleax added a commit to addaleax/ayo that referenced this pull request Aug 25, 2017

doc: fix typo in Buffer.from(string, [encoding])
PR-URL: nodejs/node#15013
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

addaleax added a commit to ayojs/ayo that referenced this pull request Aug 28, 2017

doc: fix typo in Buffer.from(string, [encoding])
PR-URL: nodejs/node#15013
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

MylesBorins added a commit that referenced this pull request Sep 10, 2017

doc: fix typo in Buffer.from(string, [encoding])
PR-URL: #15013
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

@MylesBorins MylesBorins referenced this pull request Sep 10, 2017

Merged

v8.5.0 proposal #15308

MylesBorins added a commit that referenced this pull request Sep 12, 2017

doc: fix typo in Buffer.from(string, [encoding])
PR-URL: #15013
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

MylesBorins added a commit that referenced this pull request Sep 20, 2017

doc: fix typo in Buffer.from(string, [encoding])
PR-URL: #15013
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

@MylesBorins MylesBorins referenced this pull request Sep 20, 2017

Merged

v6.11.4 proposal #15506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment