Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
meta: considerations for new core modules #15022
referenced this pull request
Aug 25, 2017
I guessed that was the reason. Personally, I disagree, when I look at PEP (Python Enhancement Proposal) I'm always impressed by the level of detail and thought that goes into pretty much any major feature. It is super helpful to learn about the thought process that went into the feature. I think we can learn a lot from them.
But if EPS is something we want to discourage, then we should change the EPS guide lines or deprecate the approach completely. But a minimum requirement for any new major feature should be to put it on the CTC agenda, even if there are no disagreements. That would have made any concerns in this cause quite obvious. This is effectively equivalent to the EPS approach, but with less documentation and more code.
@AndreasMadsen ... that's fair :-)
We've been actively moving away from putting things on the
(Of course, that's in addition to it landing as Experimental)
Especially the "
ctc-review label" part is important to me.
As for how we should deal with
pref_hooks specifically, I will defer that to @Fishrock123. It is clear to me that @Fishrock123 was against the PR and if a collaborator is against a PR then the CTC should be involved, which it wasn't. Mistakes were made, that happens and is fine, but we have to reevaluate
perf_hooks as well.