New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: increase coverage for http2 response headers #15035

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
9 participants
@apapirovski
Member

apapirovski commented Aug 25, 2017

Expanded an existing test for setting pseudo-headers on response to include all pseudo-headers, not just :status. This is a part of the request for increasing coverage for http2 as per #14985

This is my first pull request for this project but I'm hoping to continue working on additional tests for h2, so if there's any feedback I would love to hear it and incorporate it. Thanks!

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

test: increase coverage for http2 response headers
Expanded an existing test for setting pseudo-headers on response to
include all pseudo-headers, not just :status.

Refs: #14985

@mscdex mscdex added the http2 label Aug 25, 2017

@hiroppy

LGTM!

@hiroppy

This comment has been minimized.

@BridgeAR

This comment has been minimized.

Member

BridgeAR commented Aug 29, 2017

Landed in 3eb0297

@apapirovski thanks for your contribution and congratulations on your first commit to Node.js!

@BridgeAR BridgeAR closed this Aug 29, 2017

BridgeAR added a commit that referenced this pull request Aug 29, 2017

test: increase coverage for http2 response headers
Expanded an existing test for setting pseudo-headers on response to
include all pseudo-headers, not just :status.

PR-URL: #15035
Refs: #14985
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

oe added a commit to ayojs/ayo that referenced this pull request Aug 30, 2017

test: increase coverage for http2 response headers
Expanded an existing test for setting pseudo-headers on response to
include all pseudo-headers, not just :status.

PR-URL: nodejs/node#15035
Refs: nodejs/node#14985
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

oe added a commit to ayojs/ayo that referenced this pull request Aug 30, 2017

test: increase coverage for http2 response headers
Expanded an existing test for setting pseudo-headers on response to
include all pseudo-headers, not just :status.

PR-URL: nodejs/node#15035
Refs: nodejs/node#14985
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

cjihrig added a commit to cjihrig/node-1 that referenced this pull request Aug 31, 2017

test: increase coverage for http2 response headers
Expanded an existing test for setting pseudo-headers on response to
include all pseudo-headers, not just :status.

PR-URL: nodejs#15035
Refs: nodejs#14985
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@apapirovski apapirovski deleted the apapirovski:patch-test-compat-pseudo-headers branch Sep 4, 2017

MylesBorins added a commit that referenced this pull request Sep 10, 2017

test: increase coverage for http2 response headers
Expanded an existing test for setting pseudo-headers on response to
include all pseudo-headers, not just :status.

PR-URL: #15035
Refs: #14985
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@MylesBorins MylesBorins referenced this pull request Sep 10, 2017

Merged

v8.5.0 proposal #15308

MylesBorins added a commit that referenced this pull request Sep 12, 2017

test: increase coverage for http2 response headers
Expanded an existing test for setting pseudo-headers on response to
include all pseudo-headers, not just :status.

PR-URL: #15035
Refs: #14985
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment