New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: fix linter error in html.js #15063

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@targos
Member

targos commented Aug 28, 2017

Fixes an error introduced in cacce30

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tools

@targos

This comment has been minimized.

Show comment
Hide comment
@targos

targos Aug 28, 2017

Member

Error before the fix:

./git/nodejs/node/tools/doc/html.js
  199:7  error  'html' is never reassigned. Use 'const' instead  prefer-const
Member

targos commented Aug 28, 2017

Error before the fix:

./git/nodejs/node/tools/doc/html.js
  199:7  error  'html' is never reassigned. Use 'const' instead  prefer-const

@targos targos referenced this pull request Aug 28, 2017

Closed

doc: add links to alternative versions of doc #10958

3 of 3 tasks complete
@targos

This comment has been minimized.

Show comment
Hide comment
Member

targos commented Aug 28, 2017

@Trott

Trott approved these changes Aug 28, 2017

LGTM. No need to wait the full 48 hours on this, IMO.

@hiroppy

LGTM. Agree with @Trott.

@targos

This comment has been minimized.

Show comment
Hide comment
@targos

targos Aug 28, 2017

Member

Feel free to land it. I won't be able to before tomorrow.

Member

targos commented Aug 28, 2017

Feel free to land it. I won't be able to before tomorrow.

hiroppy added a commit to hiroppy/node that referenced this pull request Aug 28, 2017

tools: fix linter error in html.js
PR-URL: nodejs#15063
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@hiroppy

This comment has been minimized.

Show comment
Hide comment
@hiroppy

hiroppy Aug 28, 2017

Member

landed in 7854562

Member

hiroppy commented Aug 28, 2017

landed in 7854562

@hiroppy hiroppy closed this Aug 28, 2017

oe added a commit to ayojs/ayo that referenced this pull request Aug 30, 2017

tools: fix linter error in html.js
PR-URL: nodejs/node#15063
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>

oe added a commit to ayojs/ayo that referenced this pull request Aug 30, 2017

tools: fix linter error in html.js
PR-URL: nodejs/node#15063
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>

cjihrig added a commit to cjihrig/node-1 that referenced this pull request Aug 31, 2017

tools: fix linter error in html.js
PR-URL: nodejs#15063
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>

MylesBorins added a commit that referenced this pull request Sep 10, 2017

tools: fix linter error in html.js
PR-URL: #15063
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>

@MylesBorins MylesBorins referenced this pull request Sep 10, 2017

Merged

v8.5.0 proposal #15308

MylesBorins added a commit that referenced this pull request Sep 12, 2017

tools: fix linter error in html.js
PR-URL: #15063
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>

@targos targos deleted the targos:fix-lint-tools branch Sep 24, 2017

chris--young added a commit to chris--young/node that referenced this pull request Sep 29, 2017

tools: fix linter error in html.js
PR-URL: nodejs#15063
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>

MylesBorins added a commit that referenced this pull request Sep 29, 2017

tools: fix linter error in html.js
Backport-PR-URL: #15670
PR-URL: #15063
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>

@MylesBorins MylesBorins referenced this pull request Sep 29, 2017

Merged

v6.11.4 proposal #15506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment