New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove braces which shouldn't be there #15094

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@jscissr
Contributor

jscissr commented Aug 30, 2017

Checklist
Affected core subsystem(s)

doc, http2

@lpinca

lpinca approved these changes Aug 30, 2017

@lpinca

This comment has been minimized.

Show comment
Hide comment
@lpinca

lpinca Aug 30, 2017

Member

I guess this doesn't need to wait 48h.

Member

lpinca commented Aug 30, 2017

I guess this doesn't need to wait 48h.

@jasnell

Ha! good ole cut and paste error. Good catch.

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 30, 2017

Member

marking as don't land on v4 and v6 given that http2 doesn't exist there.

Member

jasnell commented Aug 30, 2017

marking as don't land on v4 and v6 given that http2 doesn't exist there.

jasnell added a commit that referenced this pull request Aug 30, 2017

doc: remove braces which shouldn't be there
PR-URL: #15094
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 30, 2017

Member

Landed in a80b162

Member

jasnell commented Aug 30, 2017

Landed in a80b162

@jasnell jasnell closed this Aug 30, 2017

@jscissr jscissr deleted the jscissr:braces branch Aug 30, 2017

oe added a commit to ayojs/ayo that referenced this pull request Aug 30, 2017

doc: remove braces which shouldn't be there
PR-URL: nodejs/node#15094
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

oe added a commit to ayojs/ayo that referenced this pull request Aug 30, 2017

doc: remove braces which shouldn't be there
PR-URL: nodejs/node#15094
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

cjihrig added a commit to cjihrig/node-1 that referenced this pull request Aug 31, 2017

doc: remove braces which shouldn't be there
PR-URL: nodejs#15094
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Sep 10, 2017

doc: remove braces which shouldn't be there
PR-URL: #15094
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Sep 10, 2017

Merged

v8.5.0 proposal #15308

MylesBorins added a commit that referenced this pull request Sep 12, 2017

doc: remove braces which shouldn't be there
PR-URL: #15094
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment