New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove not relevant todo from node_crypto.cc #15104

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@barnski
Contributor

barnski commented Aug 30, 2017

TODO comment from node_crypto is no longer relevant.
Unification of commented code and string_bytes code would bloat the latter.
Methods for hex encoding produce different output in both files (crypto adds colon and uses uppercase letters.)
Common path between those two is very limited now.

Checklist
  • [x ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x ] commit message follows commit guidelines
src: remove not relevant todo from node_crypto.cc
TODO comment from node_crypto is no longer relevant.
Unification of commented code and string_bytes code would bloat the latter.
Methods for hex encoding produce different output in both files (crypto adds colon and uses uppercase letters.)
Common path between those two is very limited now.
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 30, 2017

Member

ping @indutny ... this was your todo

Member

jasnell commented Aug 30, 2017

ping @indutny ... this was your todo

@BridgeAR

This comment has been minimized.

Show comment
Hide comment
@BridgeAR

BridgeAR Sep 11, 2017

Member

Well... there were so many changes since 2014 when that TODO landed that it is indeed unlikely that this is still relevant.

Member

BridgeAR commented Sep 11, 2017

Well... there were so many changes since 2014 when that TODO landed that it is indeed unlikely that this is still relevant.

@BridgeAR

I approve this because it is a very old comment and there was no further response from @indutny

@jasnell

This comment has been minimized.

Show comment
Hide comment
@BridgeAR

This comment has been minimized.

Show comment
Hide comment
@BridgeAR

BridgeAR Sep 19, 2017

Member

@barnski congratulations on your first commit to Node.js 🎉

Landed in 4dc920a

Member

BridgeAR commented Sep 19, 2017

@barnski congratulations on your first commit to Node.js 🎉

Landed in 4dc920a

@BridgeAR BridgeAR closed this Sep 19, 2017

BridgeAR added a commit that referenced this pull request Sep 19, 2017

src: remove outdated todo from node_crypto.cc
TODO comment from node_crypto is no longer relevant. Unification of
commented code and string_bytes code would bloat the latter. Methods
for hex encoding produce different output in both files (crypto adds
colon and uses uppercase letters.) Common path between those two is
very limited now.

PR-URL: #15104
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell added a commit that referenced this pull request Sep 20, 2017

src: remove outdated todo from node_crypto.cc
TODO comment from node_crypto is no longer relevant. Unification of
commented code and string_bytes code would bloat the latter. Methods
for hex encoding produce different output in both files (crypto adds
colon and uses uppercase letters.) Common path between those two is
very limited now.

PR-URL: #15104
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

Qard pushed a commit to Qard/ayo that referenced this pull request Sep 21, 2017

src: remove outdated todo from node_crypto.cc
TODO comment from node_crypto is no longer relevant. Unification of
commented code and string_bytes code would bloat the latter. Methods
for hex encoding produce different output in both files (crypto adds
colon and uses uppercase letters.) Common path between those two is
very limited now.

PR-URL: nodejs/node#15104
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Oct 17, 2017

src: remove outdated todo from node_crypto.cc
TODO comment from node_crypto is no longer relevant. Unification of
commented code and string_bytes code would bloat the latter. Methods
for hex encoding produce different output in both files (crypto adds
colon and uses uppercase letters.) Common path between those two is
very limited now.

PR-URL: #15104
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Oct 17, 2017

Merged

v6.12.0 proposal #16263

MylesBorins added a commit that referenced this pull request Oct 25, 2017

src: remove outdated todo from node_crypto.cc
TODO comment from node_crypto is no longer relevant. Unification of
commented code and string_bytes code would bloat the latter. Methods
for hex encoding produce different output in both files (crypto adds
colon and uses uppercase letters.) Common path between those two is
very limited now.

PR-URL: #15104
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Nov 3, 2017

Merged

v4.8.6 proposal #16500

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment